[jira] [Commented] (LOG4J2-813) MarkerManager Log4jMarker.hasParents() returns opposite of correct result

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LOG4J2-813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15259437#comment-15259437 ] 

ASF GitHub Bot commented on LOG4J2-813:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/logging-log4j2/pull/6


> MarkerManager Log4jMarker.hasParents() returns opposite of correct result
> -------------------------------------------------------------------------
>
>                 Key: LOG4J2-813
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-813
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: API
>    Affects Versions: 2.0.2
>            Reporter: David Erichsen
>            Priority: Minor
>              Labels: newbie
>             Fix For: 2.1
>
>
> Log4JMarker.hasParents() will return false when the marker has parents, and true when it has none. 
> The javadoc in the Marker interface indicates it should function the other way around: 
> {quote}
> "Indicates whether this Marker has references to any other Markers.  Return true if the Marker has parent Markers"
> {quote}
> The code for the implementation (that I could find) demonstrates that it would function in the opposite way as it is described in that javadoc: 
> {code}
> @Override 
> public boolean hasParents() { 
>      return this.parents == null; 
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org