You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/11 21:37:49 UTC

[GitHub] [iceberg] kbendick commented on a diff in pull request #4730: Python: Add spellcheck to the CI

kbendick commented on code in PR #4730:
URL: https://github.com/apache/iceberg/pull/4730#discussion_r870775434


##########
python/tox.ini:
##########
@@ -52,10 +52,13 @@ deps =
     black
     isort
     autoflake
+    pylint
+    pyenchant
 commands =
     autoflake -r --check --ignore-init-module-imports --remove-all-unused-imports src tests
     isort --profile black --check-only src tests
     black --line-length 130 --check --diff src tests
+    pylint --disable all --enable spelling --spelling-dict en_US --spelling-private-dict-file spellcheck-dictionary.txt en_US src tests

Review Comment:
   Question / Nit: Do we need to specify `en_US` twice? Specifically for the 2nd argument after `--spelling-private-dict-file`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org