Re: getting JSTL to work

[Ondrej Florian <on...@gmail.com>]

Hi Dan,

I found another issue which prevents JSTL to work correctly.

in launchpad/builder/src/main/bundles/list.xml
- org.apache.sling.scripting.jsp.jstl was missing
- org.apache.sling.scripting.jsp.taglib has wrong version

I added required patch to SLING-2863
=> https://issues.apache.org/jira/secure/attachment/12584550/list.xml.patch

Ondrej

On 9 May 2013, at 17:11, Dan Klco <da...@sixdimensions.com> wrote:

> Ondrej,
> 
> Thank you for all of the investigation and patch.   I have tested and committed the patch you provided, it looks good.  
> 
> Please let me know if you find anything else.  This new Resource Access Tag API is still pretty new.
> 
> Thanks again!
> 
> -Dan
> 
> -----Original Message-----
> From: Ondrej Florian [mailto:onflapp@gmail.com] 
> Sent: Thursday, May 09, 2013 9:17 AM
> To: dev@sling.apache.org
> Subject: Re: support for JSTL 1.2 
> 
> Hi Dan,
> 
> I backtracked and re-tested everything again, and yes you are right, the JSTL 1.1 should be sufficient (it works with the EL and the functions correctly).
> The real cause of the problems I've been having is documented in JIRA under SLING-2863 and SLING-2864.
> I also provided a patch to fix it in SLING-2864
> 
> Thanks,
> Ondrej 
> 
> On 8 May 2013, at 21:42, Dan Klco <da...@sixdimensions.com> wrote:
> 
>> Ondrej,
>> 
>> This sounds interesting, though it seems like Expression Language support was added in JSTL 1.1, so it should be supported currently.  Could you please create an issue and attach a patch file for the proposed change?  
>> 
>> It looks like the dependency being referenced is GlassFish's JSTL implementation, are there any concerns about including it as it is licensed under the CDDL (https://jstl.java.net/)? 
>> 
>> From what I have read, it seems like binaries licensed under the CDDL can be included in Apache projects, however since we re-wrap the Jar in a bundle I don't know if it might be problematic.  Additionally, I think we will need to include a notice that a CDDL license work has been included in Sling:
>> http://www.apache.org/legal/3party.html#category-b
>> 
>> -Dan
>> 
>> -----Original Message-----
>> From: Ondrej Florian [mailto:onflapp@gmail.com]
>> Sent: Wednesday, May 08, 2013 1:26 PM
>> To: dev@sling.apache.org
>> Subject: support for JSTL 1.2
>> 
>> Hi,
>> 
>> I'd like to contribute pom.xml for JSTL 1.2.1.
>> As far as I can see, the Sling supports 1.1.2 at the moment which doesn't seem to work with the JSP EL.
>> 
>> 
>> -----
>> No virus found in this message.
>> Checked by AVG - www.avg.com
>> Version: 2013.0.3272 / Virus Database: 3162/6287 - Release Date: 04/30/13 Internal Virus Database is out of date.
>> 
> 
> 
> 
> -----
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 2013.0.3272 / Virus Database: 3162/6287 - Release Date: 04/30/13 Internal Virus Database is out of date.
>