You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/23 14:40:33 UTC
[GitHub] [incubator-nuttx] SimonFilgis opened a new pull request, #6904: Double the MMCSD_IDLE_DELAY from 50ms to 100ms because I found one …
SimonFilgis opened a new pull request, #6904:
URL: https://github.com/apache/incubator-nuttx/pull/6904
…card that needs this to work after initial CMD0.
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #6904: drivers/mmcsd: Double the MMCSD_IDLE_DELAY from 50ms to 100ms
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #6904:
URL: https://github.com/apache/incubator-nuttx/pull/6904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6904: Double the MMCSD_IDLE_DELAY from 50ms to 100ms because I found one …
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6904:
URL: https://github.com/apache/incubator-nuttx/pull/6904#discussion_r952737517
##########
drivers/mmcsd/mmcsd_sdio.c:
##########
@@ -68,7 +68,7 @@
/* Timing (all in units of microseconds) */
#define MMCSD_POWERUP_DELAY ((useconds_t)250) /* 74 clock cycles @ 400KHz = 185uS */
-#define MMCSD_IDLE_DELAY ((useconds_t)50000) /* Short delay to allow change to IDLE state */
+#define MMCSD_IDLE_DELAY ((useconds_t)100000) /* Short delay to allow change to IDLE state */
Review Comment:
@SimonFilgis let's squash two patch into one:
git rebase --interactive HEAD~2
git push -f origin cherrypick_sd_card_timing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #6904: Double the MMCSD_IDLE_DELAY from 50ms to 100ms because I found one …
Posted by GitBox <gi...@apache.org>.
acassis commented on PR #6904:
URL: https://github.com/apache/incubator-nuttx/pull/6904#issuecomment-1224198412
Hi @SimonFilgis please squash these two commits, you can do it this way:
```
$ git rebase -i HEAD~2
```
Then after it was squashed you can push forced:
```
$ git push -f
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] davids5 commented on a diff in pull request #6904: drivers/mmcsd: Double the MMCSD_IDLE_DELAY from 50ms to 100ms
Posted by GitBox <gi...@apache.org>.
davids5 commented on code in PR #6904:
URL: https://github.com/apache/incubator-nuttx/pull/6904#discussion_r953433636
##########
drivers/mmcsd/mmcsd_sdio.c:
##########
@@ -68,7 +68,7 @@
/* Timing (all in units of microseconds) */
#define MMCSD_POWERUP_DELAY ((useconds_t)250) /* 74 clock cycles @ 400KHz = 185uS */
-#define MMCSD_IDLE_DELAY ((useconds_t)50000) /* Short delay to allow change to IDLE state */
+#define MMCSD_IDLE_DELAY ((useconds_t)100000) /* Short delay to allow change to IDLE state */
Review Comment:
```suggestion
#define MMCSD_IDLE_DELAY ((useconds_t)100000) /* Short delay to allow change to IDLE state */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6904: Double the MMCSD_IDLE_DELAY from 50ms to 100ms because I found one …
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6904:
URL: https://github.com/apache/incubator-nuttx/pull/6904#discussion_r952719587
##########
drivers/mmcsd/mmcsd_sdio.c:
##########
@@ -68,7 +68,7 @@
/* Timing (all in units of microseconds) */
#define MMCSD_POWERUP_DELAY ((useconds_t)250) /* 74 clock cycles @ 400KHz = 185uS */
-#define MMCSD_IDLE_DELAY ((useconds_t)50000) /* Short delay to allow change to IDLE state */
+#define MMCSD_IDLE_DELAY ((useconds_t)100000) /* Short delay to allow change to IDLE state */
Review Comment:
align the comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org