[GitHub] [flink] gaoyunhaii commented on a change in pull request #19061: [FLINK-26610] FileSink can not upgrade from 1.13 if the uid of the origin sink is not set

[GitBox <gi...@apache.org>]

gaoyunhaii commented on a change in pull request #19061:
URL: https://github.com/apache/flink/pull/19061#discussion_r825520024



##########
File path: flink-connectors/flink-connector-files/src/test/java/org/apache/flink/connector/file/sink/BatchExecutionFileSinkITCase.java
##########
@@ -74,7 +74,8 @@ protected JobGraph createJobGraph(String path) {
                 .map(new BatchExecutionOnceFailingMap(NUM_RECORDS, triggerFailover))
                 .setParallelism(NUM_SINKS)
                 .sinkTo(createFileSink(path))
-                .setParallelism(NUM_SINKS);
+                .setParallelism(NUM_SINKS)
+                .uid("sink");

Review comment:
       I think we'd better to set uid in the compaction related tests to also tests normal sinks works without uid.

##########
File path: flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/sink/FileSink.java
##########
@@ -378,6 +388,11 @@ public T enableCompact(final FileCompactStrategy strategy, final FileCompactor c
             return self();
         }
 
+        public T disableCompact() {

Review comment:
       Might add some comments to the `FileSink` class




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org