You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/06/24 02:00:21 UTC

[GitHub] [druid] maytasm opened a new pull request #10065: Enable query vectorization by default

maytasm opened a new pull request #10065:
URL: https://github.com/apache/druid/pull/10065


   Enable query vectorization by default
   
   ### Description
   
   Enable query vectorization by default 
   
   This PR has:
   - [x] been self-reviewed.
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
   - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] clintropolis commented on pull request #10065: Enable query vectorization by default

Posted by GitBox <gi...@apache.org>.
clintropolis commented on pull request #10065:
URL: https://github.com/apache/druid/pull/10065#issuecomment-648548278


   >Do you know if the list of things that can/can't be vectorize at https://druid.apache.org/docs/latest/querying/query-context.html#vectorization-parameters is still correct?
   
   As far as I know, yes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] clintropolis merged pull request #10065: Enable query vectorization by default

Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #10065:
URL: https://github.com/apache/druid/pull/10065


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] maytasm edited a comment on pull request #10065: Enable query vectorization by default

Posted by GitBox <gi...@apache.org>.
maytasm edited a comment on pull request #10065:
URL: https://github.com/apache/druid/pull/10065#issuecomment-648541711


   > sgtm, 🤘
   
   @clintropolis 
   I will update the default value in the doc in a bit. 
   Do you know if the list of things that can/can't be vectorize at https://druid.apache.org/docs/latest/querying/query-context.html#vectorization-parameters is still correct?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


[GitHub] [druid] maytasm commented on pull request #10065: Enable query vectorization by default

Posted by GitBox <gi...@apache.org>.
maytasm commented on pull request #10065:
URL: https://github.com/apache/druid/pull/10065#issuecomment-648541711


   > sgtm, 🤘
   @clintropolis 
   I will update the default value in the doc in a bit. 
   Do you know if the list of things that can/can't be vectorize at https://druid.apache.org/docs/latest/querying/query-context.html#vectorization-parameters is still correct?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org