You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@reef.apache.org by "Sergey Dudoladov (JIRA)" <ji...@apache.org> on 2015/09/04 18:30:46 UTC

[jira] [Commented] (REEF-703) Make NameLookupClient injectable

    [ https://issues.apache.org/jira/browse/REEF-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14731028#comment-14731028 ] 

Sergey Dudoladov commented on REEF-703:
---------------------------------------

I am figuring out the main steps to do this:
1)  The constructor at the lines 141-154 becomes @Injectable because it is the only one actually used by the code outside NameLookupClient and its tests.
2) The constructor parameters become Tang @NameParameters
3) Code that uses NameLookupClient instantiates it via Tang injections

Is it correct ?

> Make NameLookupClient injectable
> --------------------------------
>
>                 Key: REEF-703
>                 URL: https://issues.apache.org/jira/browse/REEF-703
>             Project: REEF
>          Issue Type: Task
>          Components: REEF-IO
>            Reporter: Mariia Mykhailova
>            Priority: Minor
>
> `org/apache/reef/io/network/naming/NameLookupClient.java` should be injectable, with one constructor (and others deprecated).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)