You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "riyaverm-db (via GitHub)" <gi...@apache.org> on 2024/08/05 18:14:56 UTC
[PR] [SPARK-49114] Subcategorize cannot load state store errors [spark]
riyaverm-db opened a new pull request, #47616:
URL: https://github.com/apache/spark/pull/47616
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
- Reclassify a OOM error for both state store providers in loading state store and throw an informative error message
- Within the loading state store call path, reclassify any non-error-class errors with error-class errors under the CANNOT_LOAD_STATE_STORE. category
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
We need better error classification for load state store call path for easier diagnosis and resolution of issues.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Tests passed.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49114] Sub-categorize cannot load state store errors [spark]
Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db commented on code in PR #47616:
URL: https://github.com/apache/spark/pull/47616#discussion_r1704632155
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala:
##########
@@ -284,6 +284,11 @@ private[sql] class HDFSBackedStateStoreProvider extends StateStoreProvider with
catch {
case e: SparkException if e.getErrorClass.contains("CANNOT_LOAD_STATE_STORE") =>
throw e
+ case e: OutOfMemoryError =>
+ throw QueryExecutionErrors.notEnoughMemoryToLoadStore(
+ stateStoreId.toString,
+ "HDFS",
Review Comment:
nit: `HDFS_STORE_PROVIDER`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49114] Sub-categorize cannot load state store errors [spark]
Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db commented on code in PR #47616:
URL: https://github.com/apache/spark/pull/47616#discussion_r1704694606
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala:
##########
@@ -200,8 +200,7 @@ class RocksDBFileManager(
case 2 =>
new StateStoreChangelogWriterV2(fm, changelogFile, codec)
case _ =>
- throw new IllegalArgumentException(s"Failed to find changelog writer for " +
- s"version=$changelogVersion")
+ throw QueryExecutionErrors.invalidChangeLogWriterVersion(changelogVersion)
Review Comment:
I guess no easy way to test either of these error classes right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49114] Sub-categorize cannot load state store errors [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on PR #47616:
URL: https://github.com/apache/spark/pull/47616#issuecomment-2270321688
Thanks! Merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49114] Sub-categorize cannot load state store errors [spark]
Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db commented on code in PR #47616:
URL: https://github.com/apache/spark/pull/47616#discussion_r1704694329
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -2608,6 +2608,33 @@ private[sql] object QueryExecutionErrors extends QueryErrorsBase with ExecutionE
cause = null)
}
+ def invalidChangeLogReaderVersion(version: Long): Throwable = {
+ new SparkException(
+ errorClass = "CANNOT_LOAD_STATE_STORE.INVALID_CHANGE_LOG_READER_VERSION",
+ messageParameters = Map("version" -> version.toString),
+ cause = null
+ )
+ }
+
+ def invalidChangeLogWriterVersion(version: Long): Throwable = {
+ new SparkException(
+ errorClass = "CANNOT_LOAD_STATE_STORE.INVALID_CHANGE_LOG_WRITER_VERSION",
+ messageParameters = Map("version" -> version.toString),
+ cause = null
+ )
+ }
+
+ def notEnoughMemoryToLoadStore(
+ stateStoreId: String,
Review Comment:
nit: 4 spaces for args
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49114] Sub-categorize cannot load state store errors [spark]
Posted by "riyaverm-db (via GitHub)" <gi...@apache.org>.
riyaverm-db commented on code in PR #47616:
URL: https://github.com/apache/spark/pull/47616#discussion_r1704769665
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala:
##########
@@ -200,8 +200,7 @@ class RocksDBFileManager(
case 2 =>
new StateStoreChangelogWriterV2(fm, changelogFile, codec)
case _ =>
- throw new IllegalArgumentException(s"Failed to find changelog writer for " +
- s"version=$changelogVersion")
+ throw QueryExecutionErrors.invalidChangeLogWriterVersion(changelogVersion)
Review Comment:
We can see when we call getChangeLogVersion it only returns 1 or 2 based on a boolean useColumnFamilies. Versioning is not added to change log file format so we cannot add this test @anishshri-db.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49114] Sub-categorize cannot load state store errors [spark]
Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db commented on code in PR #47616:
URL: https://github.com/apache/spark/pull/47616#discussion_r1704770668
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala:
##########
@@ -200,8 +200,7 @@ class RocksDBFileManager(
case 2 =>
new StateStoreChangelogWriterV2(fm, changelogFile, codec)
case _ =>
- throw new IllegalArgumentException(s"Failed to find changelog writer for " +
- s"version=$changelogVersion")
+ throw QueryExecutionErrors.invalidChangeLogWriterVersion(changelogVersion)
Review Comment:
Ok yea sg - this is an artifact of the version being added in the non-v0 version. but i think thats fine and the change we have should be fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49114] Subcategorize cannot load state store errors [spark]
Posted by "riyaverm-db (via GitHub)" <gi...@apache.org>.
riyaverm-db commented on code in PR #47616:
URL: https://github.com/apache/spark/pull/47616#discussion_r1704618700
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -2608,6 +2608,30 @@ private[sql] object QueryExecutionErrors extends QueryErrorsBase with ExecutionE
cause = null)
}
+ def invalidChangeLogReaderVersion(version: Long): Throwable = {
+ new SparkException(
+ errorClass = "CANNOT_LOAD_STATE_STORE.INVALID_CHANGE_LOG_READER_VERSION",
+ messageParameters = Map("version" -> version.toString),
+ cause = null
+ )
+ }
+
+ def invalidChangeLogWriterVersion(version: Long): Throwable = {
+ new SparkException(
+ errorClass = "CANNOT_LOAD_STATE_STORE.INVALID_CHANGE_LOG_WRITER_VERSION",
+ messageParameters = Map("version" -> version.toString),
+ cause = null
+ )
+ }
+
+ def notEnoughMemoryToLoadStore(stateStoreId: String, e: Throwable): Throwable = {
+ new SparkException(
+ errorClass = "CANNOT_LOAD_STATE_STORE.OUT_OF_MEMORY",
Review Comment:
Added this information to error class name as its easier to visualize in the dashboard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49114] Sub-categorize cannot load state store errors [spark]
Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db commented on code in PR #47616:
URL: https://github.com/apache/spark/pull/47616#discussion_r1704706025
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala:
##########
@@ -200,8 +200,7 @@ class RocksDBFileManager(
case 2 =>
new StateStoreChangelogWriterV2(fm, changelogFile, codec)
case _ =>
- throw new IllegalArgumentException(s"Failed to find changelog writer for " +
- s"version=$changelogVersion")
+ throw QueryExecutionErrors.invalidChangeLogWriterVersion(changelogVersion)
Review Comment:
Yea - same for OOM right. probably no easy to test this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49114] Sub-categorize cannot load state store errors [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR closed pull request #47616: [SPARK-49114] Sub-categorize cannot load state store errors
URL: https://github.com/apache/spark/pull/47616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49114] Sub-categorize cannot load state store errors [spark]
Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db commented on code in PR #47616:
URL: https://github.com/apache/spark/pull/47616#discussion_r1704707518
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala:
##########
@@ -200,8 +200,7 @@ class RocksDBFileManager(
case 2 =>
new StateStoreChangelogWriterV2(fm, changelogFile, codec)
case _ =>
- throw new IllegalArgumentException(s"Failed to find changelog writer for " +
- s"version=$changelogVersion")
+ throw QueryExecutionErrors.invalidChangeLogWriterVersion(changelogVersion)
Review Comment:
I would prefer for the version test to be added. But will let @riyaverm-db / @chaoqin-li1123 decide which route they prefer to take.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49114] Sub-categorize cannot load state store errors [spark]
Posted by "chaoqin-li1123 (via GitHub)" <gi...@apache.org>.
chaoqin-li1123 commented on code in PR #47616:
URL: https://github.com/apache/spark/pull/47616#discussion_r1704703998
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala:
##########
@@ -200,8 +200,7 @@ class RocksDBFileManager(
case 2 =>
new StateStoreChangelogWriterV2(fm, changelogFile, codec)
case _ =>
- throw new IllegalArgumentException(s"Failed to find changelog writer for " +
- s"version=$changelogVersion")
+ throw QueryExecutionErrors.invalidChangeLogWriterVersion(changelogVersion)
Review Comment:
We can manually write a "V666" changelog file to the checkpoint directory. Though I am also ok if this is not tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49114] Subcategorize cannot load state store errors [spark]
Posted by "chaoqin-li1123 (via GitHub)" <gi...@apache.org>.
chaoqin-li1123 commented on code in PR #47616:
URL: https://github.com/apache/spark/pull/47616#discussion_r1704482755
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -2608,6 +2608,30 @@ private[sql] object QueryExecutionErrors extends QueryErrorsBase with ExecutionE
cause = null)
}
+ def invalidChangeLogReaderVersion(version: Long): Throwable = {
+ new SparkException(
+ errorClass = "CANNOT_LOAD_STATE_STORE.INVALID_CHANGE_LOG_READER_VERSION",
+ messageParameters = Map("version" -> version.toString),
+ cause = null
+ )
+ }
+
+ def invalidChangeLogWriterVersion(version: Long): Throwable = {
+ new SparkException(
+ errorClass = "CANNOT_LOAD_STATE_STORE.INVALID_CHANGE_LOG_WRITER_VERSION",
+ messageParameters = Map("version" -> version.toString),
+ cause = null
+ )
+ }
+
+ def outOfMemory(stateStoreId: String, e: Throwable): Throwable = {
Review Comment:
This name is too general. Can you refer to other out of memory error in the same file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49114] Sub-categorize cannot load state store errors [spark]
Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db commented on code in PR #47616:
URL: https://github.com/apache/spark/pull/47616#discussion_r1704632339
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala:
##########
@@ -376,6 +376,11 @@ private[sql] class RocksDBStateStoreProvider
catch {
case e: SparkException if e.getErrorClass.contains("CANNOT_LOAD_STATE_STORE") =>
throw e
+ case e: OutOfMemoryError =>
+ throw QueryExecutionErrors.notEnoughMemoryToLoadStore(
+ stateStoreId.toString,
+ "RocksDB",
Review Comment:
nit: `ROCKSDB_STORE_PROVIDER`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49114] Sub-categorize cannot load state store errors [spark]
Posted by "riyaverm-db (via GitHub)" <gi...@apache.org>.
riyaverm-db commented on code in PR #47616:
URL: https://github.com/apache/spark/pull/47616#discussion_r1704707814
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala:
##########
@@ -200,8 +200,7 @@ class RocksDBFileManager(
case 2 =>
new StateStoreChangelogWriterV2(fm, changelogFile, codec)
case _ =>
- throw new IllegalArgumentException(s"Failed to find changelog writer for " +
- s"version=$changelogVersion")
+ throw QueryExecutionErrors.invalidChangeLogWriterVersion(changelogVersion)
Review Comment:
Not that I can think of. I think this should be fine since this is just adding a layer of classification before throwing uncategorized error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49114] Sub-categorize cannot load state store errors [spark]
Posted by "riyaverm-db (via GitHub)" <gi...@apache.org>.
riyaverm-db commented on PR #47616:
URL: https://github.com/apache/spark/pull/47616#issuecomment-2270169768
@HeartSaVioR requesting final review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49114] Subcategorize cannot load state store errors [spark]
Posted by "anishshri-db (via GitHub)" <gi...@apache.org>.
anishshri-db commented on code in PR #47616:
URL: https://github.com/apache/spark/pull/47616#discussion_r1704494978
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -2608,6 +2608,30 @@ private[sql] object QueryExecutionErrors extends QueryErrorsBase with ExecutionE
cause = null)
}
+ def invalidChangeLogReaderVersion(version: Long): Throwable = {
+ new SparkException(
+ errorClass = "CANNOT_LOAD_STATE_STORE.INVALID_CHANGE_LOG_READER_VERSION",
+ messageParameters = Map("version" -> version.toString),
+ cause = null
+ )
+ }
+
+ def invalidChangeLogWriterVersion(version: Long): Throwable = {
+ new SparkException(
+ errorClass = "CANNOT_LOAD_STATE_STORE.INVALID_CHANGE_LOG_WRITER_VERSION",
+ messageParameters = Map("version" -> version.toString),
+ cause = null
+ )
+ }
+
+ def notEnoughMemoryToLoadStore(stateStoreId: String, e: Throwable): Throwable = {
+ new SparkException(
+ errorClass = "CANNOT_LOAD_STATE_STORE.OUT_OF_MEMORY",
Review Comment:
Is there a way to indicate the provider too ? hdfs or rocksdb ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org