[GitHub] wujimin commented on a change in pull request #1022: [SCB-1065] when request not contain traceId, should use provider's invocation's traceId

[GitBox <gi...@apache.org>]

wujimin commented on a change in pull request #1022: [SCB-1065] when request not contain traceId,should use provider's invocation's traceId
URL: https://github.com/apache/servicecomb-java-chassis/pull/1022#discussion_r238569551
 
 

 ##########
 File path: common/common-rest/src/main/java/org/apache/servicecomb/common/rest/AbstractRestInvocation.java
 ##########
 @@ -103,7 +103,7 @@ protected void setContext() throws Exception {
     @SuppressWarnings("unchecked")
     Map<String, String> cseContext =
         JsonUtils.readValue(strCseContext.getBytes(StandardCharsets.UTF_8), Map.class);
-    invocation.setContext(cseContext);
+    invocation.addContext(cseContext);
 
 Review comment:
   highway have the same problem
   
   we can add a new method in invocation: mergeContext
   1.if new context have more items, then addAll to new context, and replace old context
   2.if new context have less items, then allAll to old context directly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services