[jira] Resolved: (TAPESTRY-1227) IUploadFile implementations should be prepared for "all" file name-separator characters in getFileName()

["Jesse Kuhnert (JIRA)" <ta...@jakarta.apache.org>]

     [ https://issues.apache.org/jira/browse/TAPESTRY-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jesse Kuhnert resolved TAPESTRY-1227.
-------------------------------------

    Resolution: Fixed
      Assignee: Jesse Kuhnert

Done.. The IUpload.getFilePath() has to remain the same though, as a file path indicates the full path string + file name. The documentation for this one makes it clear already that the paths will change depending on the client platform so I'm ok with this.

> IUploadFile implementations should be prepared for "all" file name-separator characters in getFileName()
> --------------------------------------------------------------------------------------------------------
>
>                 Key: TAPESTRY-1227
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1227
>             Project: Tapestry
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 4.1.2
>         Environment: linux server, windows client
>            Reporter: Norbert Sándor
>         Assigned To: Jesse Kuhnert
>            Priority: Critical
>             Fix For: 4.1.2
>
>
> I use the Upload component to allow files to be uploaded by users, and I have the following problem when the server and the client runs different OSs.
> 1. the file to be uploaded is selected in the browser on windows (eg. C:\Képek\image.jpg)
> 2. the file is uploaded
> 3. the application running on linux calls IUploadFile.getFileName() and gets "C:\Képek\image.jpg" instead of the expected "image.jpg"
> The problem is with UploadPart.getFileName():
>     public String getFileName()
>     {
>         File file = new File(this.getFilePath());
>         return file.getName();
>     }
> In this implementation File.getName() will use the OS's name-separator character ('/' in my case) but the uploaded file contains other characters ('\\') instead.
> If I manually edit the path of the selected file in the file browser field from "C:\Képek\image.jpg" to "C:/Képek/image.jpg" before hitting the upload button, the upload process works fine (and luckily it seems that Windows eats '/' separators as well :) ). But of course this should be handled automatically.
> Probably the same problem should be handled in IUploadFile.getFilePath() as well.
> What do you think?
> Regards:
> Norbi

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org