[GitHub] soboko commented on a change in pull request #6702: Fix for Airbnb bug PRODUCT-62223 - Text field to edit SQL snippet of a metric is not large enough for entire snippet

[GitBox <gi...@apache.org>]

soboko commented on a change in pull request #6702: Fix for Airbnb bug PRODUCT-62223 - Text field to edit SQL snippet of a metric is not large enough for entire snippet
URL: https://github.com/apache/incubator-superset/pull/6702#discussion_r248418180
 
 

 ##########
 File path: superset/assets/src/components/EditableTitle.jsx
 ##########
 @@ -68,6 +75,12 @@ export default class EditableTitle extends React.PureComponent {
     if (!this.props.canEdit || this.state.isEditing) {
       return;
     }
+
+    // For multi-line values, we save the actual rendered height of the displayed text.
+    // Later, when a textarea is constructed, we'll use this saved height.
+    this.contentHeight = (this.contentRef.current) ?
 
 Review comment:
   Makes sense, I've done that in my next commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org