You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Piotr Bzdyl (JIRA)" <ji...@codehaus.org> on 2005/08/04 11:28:57 UTC

[jira] Created: (MNG-699) Jar plugin - provide possibility to change generated jar file extension

Jar plugin - provide possibility to change generated jar file extension
-----------------------------------------------------------------------

         Key: MNG-699
         URL: http://jira.codehaus.org/browse/MNG-699
     Project: Maven 2
        Type: Improvement
  Components: maven-plugins  
 Reporter: Piotr Bzdyl


Please, provide possibility to generate artifact with extension other than 'jar' only. It is not possible to set the project (artifactId = example) artifact type i.e. to 'par' (persistance archive) or 'ejb3' and get example.par or example.ejb3 - jar plugin will always generate *.jar files.

There is no way to change this behaviour via plugin properties - jar extension is hardcoded in the plugin source code.

IMHO it would be better to generate default file extension based on the project artifact ID or let it to specify via plugin properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MNG-699) Add EJB3 support in a plugin

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-699?page=all ]
     
Stephane Nicoll closed MNG-699:
-------------------------------

    Resolution: Won't Fix

See MNG-98 and MNG-99

> Add EJB3 support in a plugin
> ----------------------------
>
>          Key: MNG-699
>          URL: http://jira.codehaus.org/browse/MNG-699
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Piotr Bzdyl
>     Assignee: Stephane Nicoll
>     Priority: Minor
>  Attachments: JarMojo.java-patch, maven2-ejb3-support.zip
>
>
> Please, provide possibility to generate artifact with extension other than 'jar' only. It is not possible to set the project (artifactId = example) artifact type i.e. to 'par' (persistance archive) or 'ejb3' and get example.par or example.ejb3 - jar plugin will always generate *.jar files.
> There is no way to change this behaviour via plugin properties - jar extension is hardcoded in the plugin source code.
> IMHO it would be better to generate default file extension based on the project artifact ID or let it to specify via plugin properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-699) Add EJB3 support in a plugin

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-699?page=comments#action_47130 ] 

Brett Porter commented on MNG-699:
----------------------------------

I trust your ability to review the patch, I'll just complain later if I see anything I don't like ;)

Why would you want to delegate application.xml generation? That would only be something in the EAR, right? 

Actually the relationship should be:
- plexus-archiver has everything possible shared (so EarArchiver might deal with application.xml?)
- maven-archiver is a layer on that that can translate MavenProject to plexus-archiver and has shared stuff amongst mojos
- mojo is configuration -> maven-archiver bridge.

> Add EJB3 support in a plugin
> ----------------------------
>
>          Key: MNG-699
>          URL: http://jira.codehaus.org/browse/MNG-699
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Piotr Bzdyl
>     Assignee: Stephane Nicoll
>     Priority: Minor
>  Attachments: JarMojo.java-patch, maven2-ejb3-support.zip
>
>
> Please, provide possibility to generate artifact with extension other than 'jar' only. It is not possible to set the project (artifactId = example) artifact type i.e. to 'par' (persistance archive) or 'ejb3' and get example.par or example.ejb3 - jar plugin will always generate *.jar files.
> There is no way to change this behaviour via plugin properties - jar extension is hardcoded in the plugin source code.
> IMHO it would be better to generate default file extension based on the project artifact ID or let it to specify via plugin properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-699) Add EJB3 support in a plugin

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-699?page=comments#action_49507 ] 

Stephane Nicoll commented on MNG-699:
-------------------------------------

Added maven-ejb3-plugin and maven-par-plugin in the sandbox, thanks.

> Add EJB3 support in a plugin
> ----------------------------
>
>          Key: MNG-699
>          URL: http://jira.codehaus.org/browse/MNG-699
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Piotr Bzdyl
>     Assignee: Stephane Nicoll
>     Priority: Minor
>  Attachments: JarMojo.java-patch, maven2-ejb3-support.zip
>
>
> Please, provide possibility to generate artifact with extension other than 'jar' only. It is not possible to set the project (artifactId = example) artifact type i.e. to 'par' (persistance archive) or 'ejb3' and get example.par or example.ejb3 - jar plugin will always generate *.jar files.
> There is no way to change this behaviour via plugin properties - jar extension is hardcoded in the plugin source code.
> IMHO it would be better to generate default file extension based on the project artifact ID or let it to specify via plugin properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-699) Add EJB3 support in a plugin

Posted by "Piotr Bzdyl (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-699?page=all ]

Piotr Bzdyl updated MNG-699:
----------------------------

    Attachment: maven2-ejb3-support.zip

I created maven-par-plugin and maven-ejb3-plugin and necessary patches in maven-artifact and maven-core components.xml files (added new packaging types: ejb3 and par).

maven-par-plugin creates persistence archives (jar files with "par" extension) including persistence.xml in its META-INF directory.

maven-ejb3-plugin creates simple jar file but with ejb3 extension.

I also patched maven-ear-plugin extending it to support par and ejb3 artifact as new ear module types.

I followed mosly JarMojo.java and RarMojo.java to create these two plugins.

Is it possible to add my plugins and patches to the maven2 source repo?

> Add EJB3 support in a plugin
> ----------------------------
>
>          Key: MNG-699
>          URL: http://jira.codehaus.org/browse/MNG-699
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Piotr Bzdyl
>     Priority: Minor
>  Attachments: JarMojo.java-patch, maven2-ejb3-support.zip
>
>
> Please, provide possibility to generate artifact with extension other than 'jar' only. It is not possible to set the project (artifactId = example) artifact type i.e. to 'par' (persistance archive) or 'ejb3' and get example.par or example.ejb3 - jar plugin will always generate *.jar files.
> There is no way to change this behaviour via plugin properties - jar extension is hardcoded in the plugin source code.
> IMHO it would be better to generate default file extension based on the project artifact ID or let it to specify via plugin properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-699) Add EJB3 support in a plugin

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-699?page=comments#action_47105 ] 

Stephane Nicoll commented on MNG-699:
-------------------------------------

This code redundacy annoys me. 

I think we need something below AbstractMojo for that kind of things. Because, all thoses plugins generates quite the same artifacts: (extension changes, some descriptor changes but basically that's the same.

What do you guys think?

> Add EJB3 support in a plugin
> ----------------------------
>
>          Key: MNG-699
>          URL: http://jira.codehaus.org/browse/MNG-699
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Piotr Bzdyl
>     Priority: Minor
>  Attachments: JarMojo.java-patch, maven2-ejb3-support.zip
>
>
> Please, provide possibility to generate artifact with extension other than 'jar' only. It is not possible to set the project (artifactId = example) artifact type i.e. to 'par' (persistance archive) or 'ejb3' and get example.par or example.ejb3 - jar plugin will always generate *.jar files.
> There is no way to change this behaviour via plugin properties - jar extension is hardcoded in the plugin source code.
> IMHO it would be better to generate default file extension based on the project artifact ID or let it to specify via plugin properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-699) Add EJB3 support in a plugin

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-699?page=comments#action_50196 ] 

Stephane Nicoll commented on MNG-699:
-------------------------------------

What do we do? Do we take MOJO-98 / MOJO-99 or the plugins I have added in the sandbox?

We also need to add the ejb3 and par lifecycles to artifacts, I've just replied on the user mailing list about this problem.

> Add EJB3 support in a plugin
> ----------------------------
>
>          Key: MNG-699
>          URL: http://jira.codehaus.org/browse/MNG-699
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Piotr Bzdyl
>     Assignee: Stephane Nicoll
>     Priority: Minor
>  Attachments: JarMojo.java-patch, maven2-ejb3-support.zip
>
>
> Please, provide possibility to generate artifact with extension other than 'jar' only. It is not possible to set the project (artifactId = example) artifact type i.e. to 'par' (persistance archive) or 'ejb3' and get example.par or example.ejb3 - jar plugin will always generate *.jar files.
> There is no way to change this behaviour via plugin properties - jar extension is hardcoded in the plugin source code.
> IMHO it would be better to generate default file extension based on the project artifact ID or let it to specify via plugin properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-699) Add EJB3 support in a plugin

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-699?page=all ]

Brett Porter updated MNG-699:
-----------------------------

    Priority: Minor  (was: Major)
     Summary: Add EJB3 support in a plugin  (was: Jar plugin - provide possibility to change generated jar file extension)

> Add EJB3 support in a plugin
> ----------------------------
>
>          Key: MNG-699
>          URL: http://jira.codehaus.org/browse/MNG-699
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Piotr Bzdyl
>     Priority: Minor

>
>
> Please, provide possibility to generate artifact with extension other than 'jar' only. It is not possible to set the project (artifactId = example) artifact type i.e. to 'par' (persistance archive) or 'ejb3' and get example.par or example.ejb3 - jar plugin will always generate *.jar files.
> There is no way to change this behaviour via plugin properties - jar extension is hardcoded in the plugin source code.
> IMHO it would be better to generate default file extension based on the project artifact ID or let it to specify via plugin properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-699) Add EJB3 support in a plugin

Posted by "David Jencks (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-699?page=comments#action_45803 ] 

David Jencks commented on MNG-699:
----------------------------------

I have no particular opinion on the idea of allowing you to change the extension of the artifact generated by the jar plugin, but would like to point out that .rar files are a standard j2ee archive type, are not jboss specific, that they have an internal structure similar to an ear, and cannot be generated correctly by the jar plugin.

> Add EJB3 support in a plugin
> ----------------------------
>
>          Key: MNG-699
>          URL: http://jira.codehaus.org/browse/MNG-699
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Piotr Bzdyl
>     Priority: Minor

>
>
> Please, provide possibility to generate artifact with extension other than 'jar' only. It is not possible to set the project (artifactId = example) artifact type i.e. to 'par' (persistance archive) or 'ejb3' and get example.par or example.ejb3 - jar plugin will always generate *.jar files.
> There is no way to change this behaviour via plugin properties - jar extension is hardcoded in the plugin source code.
> IMHO it would be better to generate default file extension based on the project artifact ID or let it to specify via plugin properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-699) Jar plugin - provide possibility to change generated jar file extension

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-699?page=comments#action_43928 ] 

Brett Porter commented on MNG-699:
----------------------------------

do "pars" and "ejb3s" add additiona information to the JAR, like war, ejb and ears do? If so, they should have their own plugins to generate them.

> Jar plugin - provide possibility to change generated jar file extension
> -----------------------------------------------------------------------
>
>          Key: MNG-699
>          URL: http://jira.codehaus.org/browse/MNG-699
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Piotr Bzdyl

>
>
> Please, provide possibility to generate artifact with extension other than 'jar' only. It is not possible to set the project (artifactId = example) artifact type i.e. to 'par' (persistance archive) or 'ejb3' and get example.par or example.ejb3 - jar plugin will always generate *.jar files.
> There is no way to change this behaviour via plugin properties - jar extension is hardcoded in the plugin source code.
> IMHO it would be better to generate default file extension based on the project artifact ID or let it to specify via plugin properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-699) Add EJB3 support in a plugin

Posted by "John Casey (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-699?page=comments#action_50493 ] 

John Casey commented on MNG-699:
--------------------------------

I've applied the new lifecycles and artifact handlers here, so whatever ejb3/par plugin implementations you want to use will have plumbing. ;)

> Add EJB3 support in a plugin
> ----------------------------
>
>          Key: MNG-699
>          URL: http://jira.codehaus.org/browse/MNG-699
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Piotr Bzdyl
>     Assignee: Stephane Nicoll
>     Priority: Minor
>  Attachments: JarMojo.java-patch, maven2-ejb3-support.zip
>
>
> Please, provide possibility to generate artifact with extension other than 'jar' only. It is not possible to set the project (artifactId = example) artifact type i.e. to 'par' (persistance archive) or 'ejb3' and get example.par or example.ejb3 - jar plugin will always generate *.jar files.
> There is no way to change this behaviour via plugin properties - jar extension is hardcoded in the plugin source code.
> IMHO it would be better to generate default file extension based on the project artifact ID or let it to specify via plugin properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-699) Add EJB3 support in a plugin

Posted by "Piotr Bzdyl (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-699?page=all ]

Piotr Bzdyl updated MNG-699:
----------------------------

    Attachment: JarMojo.java-patch

I created simple patch for JarMojo.java which allows setting different than "jar" file extension of the generated files.

It could be useful to create "par" artifact using <packaging>jar</packaging> and property <finalNameExt>par</finalNameExt> in the jar plugin configuration and then use generated artifact as of <type>par</type>.

Is it possible to commit this change into the repository?

> Add EJB3 support in a plugin
> ----------------------------
>
>          Key: MNG-699
>          URL: http://jira.codehaus.org/browse/MNG-699
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Piotr Bzdyl
>     Priority: Minor
>  Attachments: JarMojo.java-patch
>
>
> Please, provide possibility to generate artifact with extension other than 'jar' only. It is not possible to set the project (artifactId = example) artifact type i.e. to 'par' (persistance archive) or 'ejb3' and get example.par or example.ejb3 - jar plugin will always generate *.jar files.
> There is no way to change this behaviour via plugin properties - jar extension is hardcoded in the plugin source code.
> IMHO it would be better to generate default file extension based on the project artifact ID or let it to specify via plugin properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-699) Add EJB3 support in a plugin

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-699?page=comments#action_47112 ] 

Brett Porter commented on MNG-699:
----------------------------------

I'd prefer delegation over inheritence, and thought that most of the shared code was already in MavenArchiver. If you think this can be enhanced, that'd be great.

> Add EJB3 support in a plugin
> ----------------------------
>
>          Key: MNG-699
>          URL: http://jira.codehaus.org/browse/MNG-699
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Piotr Bzdyl
>     Priority: Minor
>  Attachments: JarMojo.java-patch, maven2-ejb3-support.zip
>
>
> Please, provide possibility to generate artifact with extension other than 'jar' only. It is not possible to set the project (artifactId = example) artifact type i.e. to 'par' (persistance archive) or 'ejb3' and get example.par or example.ejb3 - jar plugin will always generate *.jar files.
> There is no way to change this behaviour via plugin properties - jar extension is hardcoded in the plugin source code.
> IMHO it would be better to generate default file extension based on the project artifact ID or let it to specify via plugin properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-699) Add EJB3 support in a plugin

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-699?page=comments#action_47129 ] 

Stephane Nicoll commented on MNG-699:
-------------------------------------

Yup indeed. I woud prefer delegation as well (didn't though about it). Well, MavenArchiver could be enhanced, it does not include archiver for Ear for instance (handling application.xml file).

I'll take care of that.

Do you want to review Piot's patch before I apply it?

> Add EJB3 support in a plugin
> ----------------------------
>
>          Key: MNG-699
>          URL: http://jira.codehaus.org/browse/MNG-699
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Piotr Bzdyl
>     Priority: Minor
>  Attachments: JarMojo.java-patch, maven2-ejb3-support.zip
>
>
> Please, provide possibility to generate artifact with extension other than 'jar' only. It is not possible to set the project (artifactId = example) artifact type i.e. to 'par' (persistance archive) or 'ejb3' and get example.par or example.ejb3 - jar plugin will always generate *.jar files.
> There is no way to change this behaviour via plugin properties - jar extension is hardcoded in the plugin source code.
> IMHO it would be better to generate default file extension based on the project artifact ID or let it to specify via plugin properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-699) Add EJB3 support in a plugin

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-699?page=comments#action_49720 ] 

Brett Porter commented on MNG-699:
----------------------------------

what is required to finish this? how do they compare/relate to MOJO-98/MOJO-99?

> Add EJB3 support in a plugin
> ----------------------------
>
>          Key: MNG-699
>          URL: http://jira.codehaus.org/browse/MNG-699
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Piotr Bzdyl
>     Assignee: Stephane Nicoll
>     Priority: Minor
>  Attachments: JarMojo.java-patch, maven2-ejb3-support.zip
>
>
> Please, provide possibility to generate artifact with extension other than 'jar' only. It is not possible to set the project (artifactId = example) artifact type i.e. to 'par' (persistance archive) or 'ejb3' and get example.par or example.ejb3 - jar plugin will always generate *.jar files.
> There is no way to change this behaviour via plugin properties - jar extension is hardcoded in the plugin source code.
> IMHO it would be better to generate default file extension based on the project artifact ID or let it to specify via plugin properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-699) Jar plugin - provide possibility to change generated jar file extension

Posted by "Piotr Bzdyl (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-699?page=comments#action_43899 ] 

Piotr Bzdyl commented on MNG-699:
---------------------------------

"generate default file extension based on the project >>>>artifact ID<<<< or let it to specify via plugin properties."

I meant artifact type. Sorry for confusion.

> Jar plugin - provide possibility to change generated jar file extension
> -----------------------------------------------------------------------
>
>          Key: MNG-699
>          URL: http://jira.codehaus.org/browse/MNG-699
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Piotr Bzdyl

>
>
> Please, provide possibility to generate artifact with extension other than 'jar' only. It is not possible to set the project (artifactId = example) artifact type i.e. to 'par' (persistance archive) or 'ejb3' and get example.par or example.ejb3 - jar plugin will always generate *.jar files.
> There is no way to change this behaviour via plugin properties - jar extension is hardcoded in the plugin source code.
> IMHO it would be better to generate default file extension based on the project artifact ID or let it to specify via plugin properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-699) Add EJB3 support in a plugin

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-699?page=comments#action_46474 ] 

Brett Porter commented on MNG-699:
----------------------------------

unfortunately, this will mean that under the current architecture, the artifact will not be correctly installed/deployed. I will track down the dependant issue and link them up.

I would still prefer to see a specialist maven-ejb3-plugin, however

> Add EJB3 support in a plugin
> ----------------------------
>
>          Key: MNG-699
>          URL: http://jira.codehaus.org/browse/MNG-699
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Piotr Bzdyl
>     Priority: Minor
>  Attachments: JarMojo.java-patch
>
>
> Please, provide possibility to generate artifact with extension other than 'jar' only. It is not possible to set the project (artifactId = example) artifact type i.e. to 'par' (persistance archive) or 'ejb3' and get example.par or example.ejb3 - jar plugin will always generate *.jar files.
> There is no way to change this behaviour via plugin properties - jar extension is hardcoded in the plugin source code.
> IMHO it would be better to generate default file extension based on the project artifact ID or let it to specify via plugin properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-699) Jar plugin - provide possibility to change generated jar file extension

Posted by "Piotr Bzdyl (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-699?page=comments#action_43937 ] 

Piotr Bzdyl commented on MNG-699:
---------------------------------

Yes, par files for example add persistence.xml file to the META-INF directory, but par file is nothing more that jar file with this persistence.xml file added to the META-INF directory which can be configured and copied as all other resources (*.properties files and others which are included in the jar files).

If it still should be created by separate plugin despite this little difference from the jar files, I understand that new maven plugin should be created for this purpose. I can write such a plugin called par with goal par:par by myself, but is it possible to add it to the default maven2 distribution? I think it could be wide used by others while EJB3 is coming.

> Jar plugin - provide possibility to change generated jar file extension
> -----------------------------------------------------------------------
>
>          Key: MNG-699
>          URL: http://jira.codehaus.org/browse/MNG-699
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Piotr Bzdyl

>
>
> Please, provide possibility to generate artifact with extension other than 'jar' only. It is not possible to set the project (artifactId = example) artifact type i.e. to 'par' (persistance archive) or 'ejb3' and get example.par or example.ejb3 - jar plugin will always generate *.jar files.
> There is no way to change this behaviour via plugin properties - jar extension is hardcoded in the plugin source code.
> IMHO it would be better to generate default file extension based on the project artifact ID or let it to specify via plugin properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-699) Add EJB3 support in a plugin

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-699?page=comments#action_50245 ] 

Brett Porter commented on MNG-699:
----------------------------------

it's up to you. If you think the mojo versions are better, take those - or combine the two.

I just think the final destination should be the Apache Maven sandbox (/repos/asf/maven/sandbox)

> Add EJB3 support in a plugin
> ----------------------------
>
>          Key: MNG-699
>          URL: http://jira.codehaus.org/browse/MNG-699
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Piotr Bzdyl
>     Assignee: Stephane Nicoll
>     Priority: Minor
>  Attachments: JarMojo.java-patch, maven2-ejb3-support.zip
>
>
> Please, provide possibility to generate artifact with extension other than 'jar' only. It is not possible to set the project (artifactId = example) artifact type i.e. to 'par' (persistance archive) or 'ejb3' and get example.par or example.ejb3 - jar plugin will always generate *.jar files.
> There is no way to change this behaviour via plugin properties - jar extension is hardcoded in the plugin source code.
> IMHO it would be better to generate default file extension based on the project artifact ID or let it to specify via plugin properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-699) Jar plugin - provide possibility to change generated jar file extension

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-699?page=comments#action_44061 ] 

Brett Porter commented on MNG-699:
----------------------------------

yes, perhaps these could be added to the ejb plugin (or create an ejb3 plugin since they may be very different)

> Jar plugin - provide possibility to change generated jar file extension
> -----------------------------------------------------------------------
>
>          Key: MNG-699
>          URL: http://jira.codehaus.org/browse/MNG-699
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Piotr Bzdyl

>
>
> Please, provide possibility to generate artifact with extension other than 'jar' only. It is not possible to set the project (artifactId = example) artifact type i.e. to 'par' (persistance archive) or 'ejb3' and get example.par or example.ejb3 - jar plugin will always generate *.jar files.
> There is no way to change this behaviour via plugin properties - jar extension is hardcoded in the plugin source code.
> IMHO it would be better to generate default file extension based on the project artifact ID or let it to specify via plugin properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-699) Add EJB3 support in a plugin

Posted by "Piotr Bzdyl (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-699?page=comments#action_45801 ] 

Piotr Bzdyl commented on MNG-699:
---------------------------------

I still think that there should be possibility to create jar files with extension different than just *.jar. Look at the JBoss different artifact (sar and rar files). *.par files IMHO should be created just by jar plugin - par file is only simple jar file with included POJO classes and persistence.xml file in the META-INF directory.

I can create patch for jar plugin with added "extension" or "fileExtension" parameter. Just let me know and I will submit it here.

> Add EJB3 support in a plugin
> ----------------------------
>
>          Key: MNG-699
>          URL: http://jira.codehaus.org/browse/MNG-699
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Piotr Bzdyl
>     Priority: Minor

>
>
> Please, provide possibility to generate artifact with extension other than 'jar' only. It is not possible to set the project (artifactId = example) artifact type i.e. to 'par' (persistance archive) or 'ejb3' and get example.par or example.ejb3 - jar plugin will always generate *.jar files.
> There is no way to change this behaviour via plugin properties - jar extension is hardcoded in the plugin source code.
> IMHO it would be better to generate default file extension based on the project artifact ID or let it to specify via plugin properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-699) Add EJB3 support in a plugin

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-699?page=comments#action_49734 ] 

Brett Porter commented on MNG-699:
----------------------------------

I agree that they should be in one spot. As long as the plugins are all suitably licensed (ASL) including their dependencies, then I'd prefer to put them in the sandbox

> Add EJB3 support in a plugin
> ----------------------------
>
>          Key: MNG-699
>          URL: http://jira.codehaus.org/browse/MNG-699
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Piotr Bzdyl
>     Assignee: Stephane Nicoll
>     Priority: Minor
>  Attachments: JarMojo.java-patch, maven2-ejb3-support.zip
>
>
> Please, provide possibility to generate artifact with extension other than 'jar' only. It is not possible to set the project (artifactId = example) artifact type i.e. to 'par' (persistance archive) or 'ejb3' and get example.par or example.ejb3 - jar plugin will always generate *.jar files.
> There is no way to change this behaviour via plugin properties - jar extension is hardcoded in the plugin source code.
> IMHO it would be better to generate default file extension based on the project artifact ID or let it to specify via plugin properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-699) Add EJB3 support in a plugin

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-699?page=all ]

Stephane Nicoll updated MNG-699:
--------------------------------

    Comment: was deleted

> Add EJB3 support in a plugin
> ----------------------------
>
>          Key: MNG-699
>          URL: http://jira.codehaus.org/browse/MNG-699
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Piotr Bzdyl
>     Assignee: Stephane Nicoll
>     Priority: Minor
>  Attachments: JarMojo.java-patch, maven2-ejb3-support.zip
>
>
> Please, provide possibility to generate artifact with extension other than 'jar' only. It is not possible to set the project (artifactId = example) artifact type i.e. to 'par' (persistance archive) or 'ejb3' and get example.par or example.ejb3 - jar plugin will always generate *.jar files.
> There is no way to change this behaviour via plugin properties - jar extension is hardcoded in the plugin source code.
> IMHO it would be better to generate default file extension based on the project artifact ID or let it to specify via plugin properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-699) Add EJB3 support in a plugin

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-699?page=comments#action_50491 ] 

Stephane Nicoll commented on MNG-699:
-------------------------------------

See MOJO-98 and MOJO-99

> Add EJB3 support in a plugin
> ----------------------------
>
>          Key: MNG-699
>          URL: http://jira.codehaus.org/browse/MNG-699
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Piotr Bzdyl
>     Assignee: Stephane Nicoll
>     Priority: Minor
>  Attachments: JarMojo.java-patch, maven2-ejb3-support.zip
>
>
> Please, provide possibility to generate artifact with extension other than 'jar' only. It is not possible to set the project (artifactId = example) artifact type i.e. to 'par' (persistance archive) or 'ejb3' and get example.par or example.ejb3 - jar plugin will always generate *.jar files.
> There is no way to change this behaviour via plugin properties - jar extension is hardcoded in the plugin source code.
> IMHO it would be better to generate default file extension based on the project artifact ID or let it to specify via plugin properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-699) Add EJB3 support in a plugin

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-699?page=comments#action_49729 ] 

Stephane Nicoll commented on MNG-699:
-------------------------------------

Nothing, I just need to make sure that trygvis has committed the new lifecycle in maven-core for par and ejb3. The plugins are in the sandbox, ready to be moved to the main plugins directory.

That said, I must say that the plugins in MOJO-98 / MOJO-99 seems more complete to me that what we have in the sandbox. If we had to choose between those too, I would take the ones on the MOJO-side.

Is there any rule regarding plugin's locations? That would be good if all J2EE stuff would be on one location, wouldn't it?

Let me know and I'll finish this.

> Add EJB3 support in a plugin
> ----------------------------
>
>          Key: MNG-699
>          URL: http://jira.codehaus.org/browse/MNG-699
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Piotr Bzdyl
>     Assignee: Stephane Nicoll
>     Priority: Minor
>  Attachments: JarMojo.java-patch, maven2-ejb3-support.zip
>
>
> Please, provide possibility to generate artifact with extension other than 'jar' only. It is not possible to set the project (artifactId = example) artifact type i.e. to 'par' (persistance archive) or 'ejb3' and get example.par or example.ejb3 - jar plugin will always generate *.jar files.
> There is no way to change this behaviour via plugin properties - jar extension is hardcoded in the plugin source code.
> IMHO it would be better to generate default file extension based on the project artifact ID or let it to specify via plugin properties.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org