[jira] [Commented] (SPARK-19166) change method name from InsertIntoHadoopFsRelationCommand.deleteMatchingPartitions to InsertIntoHadoopFsRelationCommand.deleteMatchingPrefix

["Apache Spark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-19166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15817450#comment-15817450 ] 

Apache Spark commented on SPARK-19166:
--------------------------------------

User 'windpiger' has created a pull request for this issue:
https://github.com/apache/spark/pull/16545

> change method name from InsertIntoHadoopFsRelationCommand.deleteMatchingPartitions to InsertIntoHadoopFsRelationCommand.deleteMatchingPrefix
> --------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SPARK-19166
>                 URL: https://issues.apache.org/jira/browse/SPARK-19166
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>            Reporter: Song Jun
>            Priority: Minor
>
> InsertIntoHadoopFsRelationCommand.deleteMatchingPartitions delete all files that match a static prefix, such as a partition file path(/table/foo=1), or a no partition file path(/xxx/a.json).
> while the method name deleteMatchingPartitions indicates that only the partition file will be deleted. This name make a confused.
> It is better to rename the method name.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org