[GitHub] [iceberg] omarsmak commented on pull request #3162: Hive: Set catalog type to null if catalog-impl is set

[GitBox <gi...@apache.org>]

omarsmak commented on pull request #3162:
URL: https://github.com/apache/iceberg/pull/3162#issuecomment-923970511


   > For me if someone sets both `iceberg.catalog.<catalog_name>.type` and `iceberg.catalog.<catalog_name>.catalog-impl` is a wrong configuration. I think we should throw an exception instead of trying to define a precedence between the two.
   > 
   > What do you think?
   
   I thought about it for a bit and I think it is actually a good idea as well to throw an exception,  it has an advantage of being explicit to user and thus, the user is educated on how these config work.  I will update the logic shortly. Thanks for the feedback!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org