[jira] [Commented] (KAFKA-7712) Handle exceptions from immediately connected channels in Selector

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-7712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717411#comment-16717411 ] 

ASF GitHub Bot commented on KAFKA-7712:
---------------------------------------

rajinisivaram opened a new pull request #6023: KAFKA-7712: Remove channel from Selector before propagating exception
URL: https://github.com/apache/kafka/pull/6023
 
 
   Ensure that channel and selection keys are removed from `Selector` collections before propagating connect exceptions. They are currently cleared on the next `poll()`, but we can't ensure that callers (NetworkClient for example) wont try to connect again before the next `poll` and hence we should clear the collections before re-throwing exceptions from `connect()`.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Handle exceptions from immediately connected channels in Selector
> -----------------------------------------------------------------
>
>                 Key: KAFKA-7712
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7712
>             Project: Kafka
>          Issue Type: Bug
>          Components: network
>            Reporter: Rajini Sivaram
>            Assignee: Rajini Sivaram
>            Priority: Major
>             Fix For: 2.2.0
>
>
> We try to handle all possible exceptions in Selector to ensure that channels are always closed and their states kept consistent. For immediately connected channels, we should ensure that any exception during connection results in the channel being closed properly and removed from all maps. This is a very unlikely scenario, but we do already handle the exception. We should clean up properly in the catch block.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)