[GitHub] [royale-asjs] aharui edited a comment on issue #941: Recent fix for issue #811 breaks VirtualDataContainerView.removeAllItemRenderers in SparkRoyale

[GitBox <gi...@apache.org>]

aharui edited a comment on issue #941:
URL: https://github.com/apache/royale-asjs/issues/941#issuecomment-732644583


   Each component set (Basic, Jewel, MXRoyale) can have different infrastructure.  MXRoyale expects UIComponents and numElements tries to ignore other HTMLElements that are used to implement virtual lists.  In many cases, MXRoyale can re-use beads from Basic, but often that isn't the case, and many Basic beads are customized or subclassed for MXRoyale.  You can compare the beads in the defaults.css for Basic and MXRoyale and see many custom beads for MXRoyale.
   
   IMO, that should be the case here.  A solution would not patch `org.apache.royale.html.beads.VirtualDataContainerView`, as I think it works correctly for Basic.  Instead, try creating a subclass of `org.apache.royale.html.beads.VirtualDataContainerView` and override `removeAllItemRenderers`, and update the MXRoyale defaults.css


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org