You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2021/07/11 23:31:04 UTC
[GitHub] [datasketches-memory] davecromberge opened a new pull request #132: Fix build errors for multi-module build
davecromberge opened a new pull request #132:
URL: https://github.com/apache/datasketches-memory/pull/132
Multi-module dependency resolution fails for
certain plugins that require dependency resolution
in early phases of the maven lifecycle. This
behaviour is described in the associated JIRA
ticket: https://issues.apache.org/jira/browse/MNG-3283
This pull-request aims to address instability
due to dependency resolution by adopting the
suggestion in the linked ticket above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-memory] davecromberge merged pull request #132: Fix build errors for multi-module build
Posted by GitBox <gi...@apache.org>.
davecromberge merged pull request #132:
URL: https://github.com/apache/datasketches-memory/pull/132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-memory] leerho commented on pull request #132: Fix build errors for multi-module build
Posted by GitBox <gi...@apache.org>.
leerho commented on pull request #132:
URL: https://github.com/apache/datasketches-memory/pull/132#issuecomment-878520978
See comments in dev@
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-memory] leerho commented on pull request #132: Fix build errors for multi-module build
Posted by GitBox <gi...@apache.org>.
leerho commented on pull request #132:
URL: https://github.com/apache/datasketches-memory/pull/132#issuecomment-878623710
(previous comment not finished) : ...
**/target/**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-memory] leerho commented on pull request #132: Fix build errors for multi-module build
Posted by GitBox <gi...@apache.org>.
leerho commented on pull request #132:
URL: https://github.com/apache/datasketches-memory/pull/132#issuecomment-877962645
I reviewed your PR, approved it and made some comments in the PR.
Lee.
On Sun, Jul 11, 2021 at 4:37 PM David Cromberge ***@***.***>
wrote:
> @davecromberge <https://github.com/davecromberge> requested your review
> on: #132 <https://github.com/apache/datasketches-memory/pull/132> Fix
> build errors for multi-module build.
>
> —
> You are receiving this because your review was requested.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/datasketches-memory/pull/132#event-5004628017>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ADCXRQSFQG27KSGLUOFKIPTTXITKDANCNFSM5AFYERNA>
> .
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-memory] davecromberge commented on pull request #132: Fix build errors for multi-module build
Posted by GitBox <gi...@apache.org>.
davecromberge commented on pull request #132:
URL: https://github.com/apache/datasketches-memory/pull/132#issuecomment-878302380
@leerho thank you for your review comments.
> The readme says that only JDK 8,9 and 11 are required to compile. First, using mvn clean compile I could not get it to compile, even using the --toolchains tools/toolchains.xml option unless the installed JDKs on my system matched both the list of JDKs in the GitHub actions matrix [] command as well as the specified JDKs in the toolchains.xml. So I don't know if I was doing something else wrong. If this is true this means that the developer user may need to modify these two lists based on what JDKs are available in the developer's system; and a note to this effect should also be in the README.
I have added additional documentation in line with your suggestion to clarify how to setup a local environment for use with toolchains.
> When loading this into Eclipse, it immediately showed an error in
datasketches-memory-java8-tests/src/test/java/org/apache/datasketches/memory/test/VirtualMachineMemoryTest.java
This file has the package declaration of
package org.apache.datasketches.memory.test.internal; while it is in the org.apache.datasketches.memory.test package.
I am puzzled how you were able to get this to compile without errors.
This was unfortunately introduced whilst I migrated the changes for my PR from one branch to another, and would have been checked in the former branch but missed during the migration. Interesting, this does not result in a compiler error in maven or IntelliJ, for example using:
$ mvn process-classes compiler:testCompile
The Eclipse compiler correctly detected the issue and this has now been corrected.
> Nonetheless, Eclipse had numerous other problems too, and I am hoping your PR will address those. I was not able to get Eclipse to work.
I have updated the development documentation for Eclipse to help address any outstanding issues. Also, Eclipse is strict in compiling the module definition for the `datasketches-java9-tests`, as it detects that there is a mixture of classpath and module path usage due to the MultiRelease JAR. The solution I have adopted is to remove the troublesome `datasketches-java9-tests` module to ensure Eclipse builds correctly.
Finally, whilst I have tested locally, I would appreciate if you could try out this branch to give me an opportunity to further refine the documentation and/or code before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-memory] leerho edited a comment on pull request #132: Fix build errors for multi-module build
Posted by GitBox <gi...@apache.org>.
leerho edited a comment on pull request #132:
URL: https://github.com/apache/datasketches-memory/pull/132#issuecomment-878623710
(previous comment not finished) : ...
\*\*/target/\*\*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-memory] leerho commented on pull request #132: Fix build errors for multi-module build
Posted by GitBox <gi...@apache.org>.
leerho commented on pull request #132:
URL: https://github.com/apache/datasketches-memory/pull/132#issuecomment-877961255
Two comments:
- The readme says that only JDK 8,9 and 11 are required to compile. First, using `mvn clean compile` I could not get it to compile, even using the `--toolchains tools/toolchains.xml` option unless the installed JDKs on my system matched both the list of JDKs in the GitHub actions matrix [] command as well as the specified JDKs in the `toolchains.xml`. So I don't know if I was doing something else wrong. If this is true this means that the developer user may need to modify these two lists based on what JDKs are available in the developer's system; and a note to this effect should also be in the README.
- When loading this into Eclipse, it immediately showed an error in
`datasketches-memory-java8-tests/src/test/java/org/apache/datasketches/memory/test/VirtualMachineMemoryTest.java`
This file has the package declaration of
`package org.apache.datasketches.memory.test.internal;` while it is in the `org.apache.datasketches.memory.test` package.
I am puzzled how you were able to get this to compile without errors.
Nonetheless, Eclipse had numerous other problems too, and I am hoping your PR will address those. I was not able to get Eclipse to work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
[GitHub] [datasketches-memory] davecromberge commented on pull request #132: Fix build errors for multi-module build
Posted by GitBox <gi...@apache.org>.
davecromberge commented on pull request #132:
URL: https://github.com/apache/datasketches-memory/pull/132#issuecomment-877879111
@leerho I've opened this PR with the intent to address some of the issues you raised in the dev mailing group - I'd be grateful if you could review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org