You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2020/08/20 17:07:52 UTC

Review Request 72793: Added discarding a future returned by get() into the docker store test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72793/
-----------------------------------------------------------

Review request for mesos and Qian Zhang.


Bugs: MESOS-10169
    https://issues.apache.org/jira/browse/MESOS-10169


Repository: mesos


Description
-------

This patch extends the `PullingSameImageSimultaneously` test
with discarding one of the futures returned by `store->get()`
and making sure that the pull still completes.


Diffs
-----

  src/tests/containerizer/provisioner_docker_tests.cpp c3ef4a0beb3091043f51ab840adbb5da9da400fc 


Diff: https://reviews.apache.org/r/72793/diff/1/


Testing
-------


Thanks,

Andrei Sekretenko


Re: Review Request 72793: Added discarding a future returned by get() into the docker store test.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72793/#review221791
-----------------------------------------------------------


Ship it!




Ship It!

- Qian Zhang


On Aug. 21, 2020, 1:07 a.m., Andrei Sekretenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72793/
> -----------------------------------------------------------
> 
> (Updated Aug. 21, 2020, 1:07 a.m.)
> 
> 
> Review request for mesos and Qian Zhang.
> 
> 
> Bugs: MESOS-10169
>     https://issues.apache.org/jira/browse/MESOS-10169
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch extends the `PullingSameImageSimultaneously` test
> with discarding one of the futures returned by `store->get()`
> and making sure that the pull still completes.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/provisioner_docker_tests.cpp c3ef4a0beb3091043f51ab840adbb5da9da400fc 
> 
> 
> Diff: https://reviews.apache.org/r/72793/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Sekretenko
> 
>