You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2018/06/20 06:16:51 UTC
[GitHub] zeppelin pull request #3037: [ZEPPELIN-3555] Zeppelin auth fails if `activeD...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/3037
[ZEPPELIN-3555] Zeppelin auth fails if `activeDirectoryRealm.groupRolesMap` is not specified.
### What is this PR for?
Zeppelin auth fails if `activeDirectoryRealm.groupRolesMap` is not specified.
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-3555](https://issues.apache.org/jira/browse/ZEPPELIN-3555)
### How should this be tested?
Zeppelin auth fails if `groupRolesMap` is not specified in `ActiveDirectoryGroupRealm`, with this PR following config should work;
```
activeDirectoryRealm = org.apache.zeppelin.realm.ActiveDirectoryGroupRealm
activeDirectoryRealm.systemUsername = userNameA
activeDirectoryRealm.systemPassword = passwordA
activeDirectoryRealm.searchBase = CN=Users,DC=SOME_GROUP,DC=COMPANY,DC=COM
activeDirectoryRealm.url = ldap://ldap.test.com:389
#activeDirectoryRealm.groupRolesMap = "CN=admin,OU=groups,DC=SOME_GROUP,DC=COMPANY,DC=COM":"admin","CN=finance,OU=groups,DC=SOME_GROUP,DC=COMPANY,DC=COM":"finance","CN=hr,OU=groups,DC=SOME_GROUP,DC=COMPANY,DC=COM":"hr"
activeDirectoryRealm.authorizationCachingEnabled = false
```
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3555
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3037.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3037
----
commit 6cb408a6e5741ee4f52672def084d4eee546948a
Author: Prabhjyot Singh <pr...@...>
Date: 2018-06-20T06:13:45Z
ZEPPELIN-3555: fix NPE in groupRolesMap for ActiveDirectoryGroupRealm
Change-Id: Ifb172642cb4b8579eeb71255358b456f378c9143
----
---
[GitHub] zeppelin pull request #3037: [ZEPPELIN-3555] Zeppelin auth fails if `activeD...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/3037
---
[GitHub] zeppelin issue #3037: [ZEPPELIN-3555] Zeppelin auth fails if `activeDirector...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3037
Thanks for the review will merge this if no more discussion.
---
[GitHub] zeppelin issue #3037: [ZEPPELIN-3555] Zeppelin auth fails if `activeDirector...
Posted by VipinRathor <gi...@git.apache.org>.
Github user VipinRathor commented on the issue:
https://github.com/apache/zeppelin/pull/3037
LGTM!
---
[GitHub] zeppelin issue #3037: [ZEPPELIN-3555] Zeppelin auth fails if `activeDirector...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/3037
@VipinRathor @zjffdu can you help review this.
---
[GitHub] zeppelin issue #3037: [ZEPPELIN-3555] Zeppelin auth fails if `activeDirector...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/3037
LGTM
---