[jira] Issue Comment Edited: (CXF-2652) UriInfo.getAbsolutePath throws "java.net.URISyntaxException: Illegal character in path" when there is an encoded space in the request URI

["Julien Wajsberg (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CXF-2652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829611#action_12829611 ] 

Julien Wajsberg edited comment on CXF-2652 at 2/4/10 3:01 PM:
--------------------------------------------------------------

(sorry for spamming)

A code which gives the correct value is :
{code}
private URI getAbsolutePathUri(UriInfo uriInfo) {
	String path = uriInfo.getPath(false);
	if (path.startsWith("/")) {
		path = path.replaceFirst("\\/+", "");
	}
	URI baseUri = uriInfo.getBaseUri();
	String base = baseUri.toString();
	if (! base.endsWith("/")) {
		base += "/";
		baseUri = URI.create(base);
	}
	URI location = baseUri.resolve(path);
	return location;
}
{code}

      was (Author: flashfr):
    (sorry for spamming)

A code which gives the correct value is :
{code}
private URI getAbsolutePathUri(UriInfo uriInfo) {
	String path = uriInfo.getPath(false);
	if (path.startsWith("/")) {
		path = path.replaceFirst("\\/+", "");
	}
	URI location = uriInfo.getBaseUri().resolve(path);
	return location;
}
{code}
  
> UriInfo.getAbsolutePath throws "java.net.URISyntaxException: Illegal character in path" when there is an encoded space in the request URI
> -----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: CXF-2652
>                 URL: https://issues.apache.org/jira/browse/CXF-2652
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>    Affects Versions: 2.2.6
>         Environment: Used with Spring
>            Reporter: Julien Wajsberg
>
> I tried this simple code :
> {code}
> package mypackage;
> import javax.ws.rs.GET;
> import javax.ws.rs.Path;
> import javax.ws.rs.PathParam;
> import javax.ws.rs.core.Context;
> import javax.ws.rs.core.UriInfo;
> @Path("uri")
> public class UriService {
>     @GET
>     @Path("something/{id}")
>     public void addSomething(String string, @Context UriInfo uriInfo, @PathParam("id") String id) {
>     	System.out.println("getPath -> " + uriInfo.getPath());
>     	System.out.println("getBasePath -> " + uriInfo.getBaseUri());
>     	System.out.println("getAbsolutePath -> " + uriInfo.getBaseUri().resolve(uriInfo.getPath(false)));
>     	System.out.println("getAbsolutePath -> " + uriInfo.getAbsolutePath());
>     }
> }
> {code}
> With a Spring-based setup and default beans.xml taken from the user guide.
> Then we can use a normal browser .
> With "http://localhost:9080/Uritest/rest/uri/something/3", we get in stdout :
> {panel}
> getPath -> /uri/something/3
> getBasePath -> http://localhost:9080/Uritest/rest
> getAbsolutePath -> http://localhost:9080/uri/something/3
> getAbsolutePath -> http://localhost:9080/Uritest/rest/uri/something/3
> {panel}
> But with "http://localhost:9080/Uritest/rest/uri/something/3 4", we get an exception :
> {noformat}
> java.net.URISyntaxException: Illegal character in path at index 50: http://localhost:9080/Uritest/rest/uri/something/3 4
> {noformat}
> And in stdout :
> {panel}
> getPath -> /uri/something/3 4
> getBasePath -> http://localhost:9080/Uritest/rest
> getAbsolutePath -> http://localhost:9080/uri/something/3%204
> {panel}
> NB : in JAX-RS javadoc, it's said that "getAbsolutePath()" is a shortcut to uriInfo.getBase().resolve(uriInfo.getPath())", which is plain wrong, because :
> # getBase doesn't exist, that's getBaseUri
> # getPath as returned by CXF begins with a slash ("/") so "resolve" doesn't do what we want here. (maybe another bug ? tell me and I'll create another issue)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.