You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/04/02 12:02:08 UTC

[GitHub] [tinkerpop] spmallette commented on issue #1275: gremlin-javascript: remove session close method

spmallette commented on issue #1275: gremlin-javascript: remove session close method
URL: https://github.com/apache/tinkerpop/pull/1275#issuecomment-607803254
 
 
   I think there might be some confusion. For `3.3-dev` you were just going to remove this:
   
   ```js
   const args = {'gremlin': 'session.close()'};
   ```
   
   Recall, that the "close" message specification does not call for the use of that "gremlin" argument. That small change was all that needed to go to `3.3-dev`.
   
   This PR that removes the sending of the "close" message should be targeted at the `master` branch. It is on the `master` branch that the Java driver no longer supports sending it and we want to match that functionality there. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services