You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Hielke Hoeve (JIRA)" <ji...@apache.org> on 2013/02/18 11:59:12 UTC

[jira] [Commented] (WICKET-4976) WicketTester#startComponent(Component) doesn't detach the component and request cycle

    [ https://issues.apache.org/jira/browse/WICKET-4976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580541#comment-13580541 ] 

Hielke Hoeve commented on WICKET-4976:
--------------------------------------

This task now breaks one of WiQuery's testcases (as far as I could see, comparing wicket versions in github is impossible):

https://github.com/WiQuery/wiquery/blob/master/wiquery-jquery-ui/src/test/java/org/odlabs/wiquery/ui/button/ButtonTestCase.java#L151

tester.startPage(new ButtonTestPage(true));

The exception is: 

org.apache.wicket.WicketRuntimeException: No RequestCycle is currently set!
	at org.apache.wicket.Component.getRequest(Component.java:1795)
	at org.apache.wicket.markup.html.WebPage.dirty(WebPage.java:318)
	at org.apache.wicket.Page.init(Page.java:715)
	at org.apache.wicket.Page.<init>(Page.java:182)
	at org.apache.wicket.Page.<init>(Page.java:136)
	at org.apache.wicket.markup.html.WebPage.<init>(WebPage.java:76)
	at org.odlabs.wiquery.ui.button.ButtonTestPage.<init>(ButtonTestPage.java:26)
	at org.odlabs.wiquery.ui.button.ButtonTestCase.testSetLabelModel(ButtonTestCase.java:151)

This works in Wicket 6.2.0 through 6.4.0. When rewriting this test with the following call:

tester.startPage(ButtonTestPage.class);

The testcase works.
                
> WicketTester#startComponent(Component) doesn't detach the component and request cycle
> -------------------------------------------------------------------------------------
>
>                 Key: WICKET-4976
>                 URL: https://issues.apache.org/jira/browse/WICKET-4976
>             Project: Wicket
>          Issue Type: Sub-task
>          Components: wicket
>    Affects Versions: 1.5.9, 6.4.0
>            Reporter: Martin Grigorov
>            Assignee: Martin Grigorov
>            Priority: Minor
>             Fix For: 1.5.10, 6.5.0
>
>
> WicketTester#startComponent(Component) doesn't detach the component and request cycle

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira