You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/08/15 08:55:08 UTC
[GitHub] [iceberg] XN137 opened a new pull request, #5528: Build: Enforce logging conventions with errorprone
XN137 opened a new pull request, #5528:
URL: https://github.com/apache/iceberg/pull/5528
These errorprone checks are just warnings by default:
https://github.com/palantir/gradle-baseline/blob/4.0.0/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/Slf4jThrowable.java#L41
https://github.com/palantir/gradle-baseline/blob/4.0.0/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/LoggerEnclosingClass.java#L41
https://github.com/palantir/gradle-baseline/blob/4.0.0/baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/PreferStaticLoggers.java#L43
Since the codebase has no violations we should increase the severity to
ERROR and enforce these conventions automatically going forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] Fokko merged pull request #5528: Build: Enforce logging conventions with errorprone
Posted by GitBox <gi...@apache.org>.
Fokko merged PR #5528:
URL: https://github.com/apache/iceberg/pull/5528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] XN137 commented on pull request #5528: Build: Enforce logging conventions with errorprone
Posted by GitBox <gi...@apache.org>.
XN137 commented on PR #5528:
URL: https://github.com/apache/iceberg/pull/5528#issuecomment-1214815065
@nastra even on the `develop` branch of `gradle-baseline` these are all still warnings.
so i would consider upgrading the plugin a separate piece of work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on pull request #5528: Build: Enforce logging conventions with errorprone
Posted by GitBox <gi...@apache.org>.
nastra commented on PR #5528:
URL: https://github.com/apache/iceberg/pull/5528#issuecomment-1214810124
A bunch of stuff around logging changed in the most recent version of the `gradle-baseline-java` plugin, so maybe we should first upgrad to that version and then re-evaluate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org