You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by John Sirois <js...@apache.org> on 2016/01/16 01:40:16 UTC
Review Request 42375: Make required mesos log args required.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42375/
-----------------------------------------------------------
Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
Bugs: AURORA-1587
https://issues.apache.org/jira/browse/AURORA-1587
Repository: aurora
Description
-------
Both -native_log_file_path and -native_log_zk_group_path are required
but they were not validated (-native_log_file_path) and validated too
late in a provider (-native_log_zk_group_path) to provide useful
failure messages. Correct this and make the arguments required in
the arg parsing phase.
src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
Diffs
-----
src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 906b3494ab35e70397927ec13f3d9a814059575c
Diff: https://reviews.apache.org/r/42375/diff/
Testing
-------
```
./gradlew clean distZip
unzip -qd /tmp/ dist/distributions/aurora-scheduler-0.12.0-SNAPSHOT.zip
/tmp/aurora-scheduler-0.12.0-SNAPSHOT/bin/aurora-scheduler
...
-zk_session_timeout=(4, secs)
The ZooKeeper session timeout.
(org.apache.aurora.scheduler.zookeeper.guice.client.flagged.FlaggedClientConfig.zk_session_timeout)
-------------------------------------------------------------------------
E0115 17:39:48.671 [main, SchedulerMain:217] Failed to apply arguments
java.lang.IllegalArgumentException: Value did not meet constraints:
native_log_zk_group_path - Value must not be null.
mesos_master_address - Value must not be null.
backup_dir - Value must not be null.
serverset_path - Value must not be null.
cluster_name - Value must not be null.
native_log_file_path - Value must not be null.
java.lang.IllegalArgumentException: Value did not meet constraints:
native_log_zk_group_path - Value must not be null.
mesos_master_address - Value must not be null.
backup_dir - Value must not be null.
serverset_path - Value must not be null.
cluster_name - Value must not be null.
native_log_file_path - Value must not be null.
at org.apache.aurora.common.args.ArgScanner.process(ArgScanner.java:437) ~[commons-0.12.0-SNAPSHOT.jar:na]
at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:212) ~[commons-0.12.0-SNAPSHOT.jar:na]
at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:190) ~[commons-0.12.0-SNAPSHOT.jar:na]
at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:167) ~[commons-0.12.0-SNAPSHOT.jar:na]
at org.apache.aurora.scheduler.app.SchedulerMain.applyStaticArgumentValues(SchedulerMain.java:230) [aurora-0.12.0-SNAPSHOT.jar:na]
at org.apache.aurora.scheduler.app.SchedulerMain.main(SchedulerMain.java:203) [aurora-0.12.0-SNAPSHOT.jar:na]
```
Thanks,
John Sirois
Re: Review Request 42375: Make required mesos log args required.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42375/#review114821
-----------------------------------------------------------
Master (b563679) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 16, 2016, 12:40 a.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42375/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2016, 12:40 a.m.)
>
>
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
>
>
> Bugs: AURORA-1587
> https://issues.apache.org/jira/browse/AURORA-1587
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Both -native_log_file_path and -native_log_zk_group_path are required
> but they were not validated (-native_log_file_path) and validated too
> late in a provider (-native_log_zk_group_path) to provide useful
> failure messages. Correct this and make the arguments required in
> the arg parsing phase.
>
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 906b3494ab35e70397927ec13f3d9a814059575c
>
> Diff: https://reviews.apache.org/r/42375/diff/
>
>
> Testing
> -------
>
> ```
> ./gradlew clean distZip
> unzip -qd /tmp/ dist/distributions/aurora-scheduler-0.12.0-SNAPSHOT.zip
> /tmp/aurora-scheduler-0.12.0-SNAPSHOT/bin/aurora-scheduler
> ...
> -zk_session_timeout=(4, secs)
> The ZooKeeper session timeout.
> (org.apache.aurora.scheduler.zookeeper.guice.client.flagged.FlaggedClientConfig.zk_session_timeout)
> -------------------------------------------------------------------------
> E0115 17:39:48.671 [main, SchedulerMain:217] Failed to apply arguments
> java.lang.IllegalArgumentException: Value did not meet constraints:
> native_log_zk_group_path - Value must not be null.
> mesos_master_address - Value must not be null.
> backup_dir - Value must not be null.
> serverset_path - Value must not be null.
> cluster_name - Value must not be null.
> native_log_file_path - Value must not be null.
> java.lang.IllegalArgumentException: Value did not meet constraints:
> native_log_zk_group_path - Value must not be null.
> mesos_master_address - Value must not be null.
> backup_dir - Value must not be null.
> serverset_path - Value must not be null.
> cluster_name - Value must not be null.
> native_log_file_path - Value must not be null.
>
> at org.apache.aurora.common.args.ArgScanner.process(ArgScanner.java:437) ~[commons-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:212) ~[commons-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:190) ~[commons-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:167) ~[commons-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.scheduler.app.SchedulerMain.applyStaticArgumentValues(SchedulerMain.java:230) [aurora-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.scheduler.app.SchedulerMain.main(SchedulerMain.java:203) [aurora-0.12.0-SNAPSHOT.jar:na]
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42375: Make required mesos log args required.
Posted by Dmitriy Shirchenko <ca...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42375/#review114827
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitriy Shirchenko
On Jan. 16, 2016, 12:40 a.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42375/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2016, 12:40 a.m.)
>
>
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
>
>
> Bugs: AURORA-1587
> https://issues.apache.org/jira/browse/AURORA-1587
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Both -native_log_file_path and -native_log_zk_group_path are required
> but they were not validated (-native_log_file_path) and validated too
> late in a provider (-native_log_zk_group_path) to provide useful
> failure messages. Correct this and make the arguments required in
> the arg parsing phase.
>
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 906b3494ab35e70397927ec13f3d9a814059575c
>
> Diff: https://reviews.apache.org/r/42375/diff/
>
>
> Testing
> -------
>
> ```
> ./gradlew clean distZip
> unzip -qd /tmp/ dist/distributions/aurora-scheduler-0.12.0-SNAPSHOT.zip
> /tmp/aurora-scheduler-0.12.0-SNAPSHOT/bin/aurora-scheduler
> ...
> -zk_session_timeout=(4, secs)
> The ZooKeeper session timeout.
> (org.apache.aurora.scheduler.zookeeper.guice.client.flagged.FlaggedClientConfig.zk_session_timeout)
> -------------------------------------------------------------------------
> E0115 17:39:48.671 [main, SchedulerMain:217] Failed to apply arguments
> java.lang.IllegalArgumentException: Value did not meet constraints:
> native_log_zk_group_path - Value must not be null.
> mesos_master_address - Value must not be null.
> backup_dir - Value must not be null.
> serverset_path - Value must not be null.
> cluster_name - Value must not be null.
> native_log_file_path - Value must not be null.
> java.lang.IllegalArgumentException: Value did not meet constraints:
> native_log_zk_group_path - Value must not be null.
> mesos_master_address - Value must not be null.
> backup_dir - Value must not be null.
> serverset_path - Value must not be null.
> cluster_name - Value must not be null.
> native_log_file_path - Value must not be null.
>
> at org.apache.aurora.common.args.ArgScanner.process(ArgScanner.java:437) ~[commons-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:212) ~[commons-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:190) ~[commons-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:167) ~[commons-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.scheduler.app.SchedulerMain.applyStaticArgumentValues(SchedulerMain.java:230) [aurora-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.scheduler.app.SchedulerMain.main(SchedulerMain.java:203) [aurora-0.12.0-SNAPSHOT.jar:na]
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42375: Make required mesos log args required.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42375/#review114840
-----------------------------------------------------------
Master (b563679) is green with this patch.
./build-support/jenkins/build.sh
However, it appears that it might lack test coverage.
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 16, 2016, 3:41 a.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42375/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2016, 3:41 a.m.)
>
>
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
>
>
> Bugs: AURORA-1587
> https://issues.apache.org/jira/browse/AURORA-1587
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Both -native_log_file_path and -native_log_zk_group_path are required
> but they were not validated (-native_log_file_path) and validated too
> late in a provider (-native_log_zk_group_path) to provide useful
> failure messages. Correct this and make the arguments required in
> the arg parsing phase.
>
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 906b3494ab35e70397927ec13f3d9a814059575c
>
> Diff: https://reviews.apache.org/r/42375/diff/
>
>
> Testing
> -------
>
> ```
> ./gradlew clean distZip
> unzip -qd /tmp/ dist/distributions/aurora-scheduler-0.12.0-SNAPSHOT.zip
> /tmp/aurora-scheduler-0.12.0-SNAPSHOT/bin/aurora-scheduler \
> -mesos_master_address=localhost:5050 \
> -backup_dir=/tmp \
> -serverset_path=/aurora \
> -cluster_name=test -zk_endpoints=localhost:2181
> ...
> I0115 20:18:37.890 [main, ArgScanner:443] zk_in_proc (org.apache.aurora.scheduler.zookeeper.guice.client.flagged.FlaggedClientConfig.zk_in_proc): false
> I0115 20:18:37.890 [main, ArgScanner:443] zk_session_timeout (org.apache.aurora.scheduler.zookeeper.guice.client.flagged.FlaggedClientConfig.zk_session_timeout): (4, secs)
> I0115 20:18:37.890 [main, ArgScanner:445] -------------------------------------------------------------------------
> Exception in thread "main" java.lang.IllegalStateException: A value for the -native_log_file_path flag must be supplied
> at org.apache.aurora.scheduler.log.mesos.MesosLogStreamModule.getRequiredArg(MesosLogStreamModule.java:99)
> at org.apache.aurora.scheduler.log.mesos.MesosLogStreamModule.<init>(MesosLogStreamModule.java:110)
> at org.apache.aurora.scheduler.app.SchedulerMain.main(SchedulerMain.java:209)
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42375: Make required mesos log args required.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42375/
-----------------------------------------------------------
(Updated Jan. 15, 2016, 8:41 p.m.)
Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
Bugs: AURORA-1587
https://issues.apache.org/jira/browse/AURORA-1587
Repository: aurora
Description
-------
Both -native_log_file_path and -native_log_zk_group_path are required
but they were not validated (-native_log_file_path) and validated too
late in a provider (-native_log_zk_group_path) to provide useful
failure messages. Correct this and make the arguments required in
the arg parsing phase.
src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
Diffs
-----
src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 906b3494ab35e70397927ec13f3d9a814059575c
Diff: https://reviews.apache.org/r/42375/diff/
Testing (updated)
-------
```
./gradlew clean distZip
unzip -qd /tmp/ dist/distributions/aurora-scheduler-0.12.0-SNAPSHOT.zip
/tmp/aurora-scheduler-0.12.0-SNAPSHOT/bin/aurora-scheduler \
-mesos_master_address=localhost:5050 \
-backup_dir=/tmp \
-serverset_path=/aurora \
-cluster_name=test -zk_endpoints=localhost:2181
...
I0115 20:18:37.890 [main, ArgScanner:443] zk_in_proc (org.apache.aurora.scheduler.zookeeper.guice.client.flagged.FlaggedClientConfig.zk_in_proc): false
I0115 20:18:37.890 [main, ArgScanner:443] zk_session_timeout (org.apache.aurora.scheduler.zookeeper.guice.client.flagged.FlaggedClientConfig.zk_session_timeout): (4, secs)
I0115 20:18:37.890 [main, ArgScanner:445] -------------------------------------------------------------------------
Exception in thread "main" java.lang.IllegalStateException: A value for the -native_log_file_path flag must be supplied
at org.apache.aurora.scheduler.log.mesos.MesosLogStreamModule.getRequiredArg(MesosLogStreamModule.java:99)
at org.apache.aurora.scheduler.log.mesos.MesosLogStreamModule.<init>(MesosLogStreamModule.java:110)
at org.apache.aurora.scheduler.app.SchedulerMain.main(SchedulerMain.java:209)
```
Thanks,
John Sirois
Re: Review Request 42375: Make required mesos log args required.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42375/
-----------------------------------------------------------
(Updated Jan. 15, 2016, 8:35 p.m.)
Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
Bugs: AURORA-1587
https://issues.apache.org/jira/browse/AURORA-1587
Repository: aurora
Description
-------
Both -native_log_file_path and -native_log_zk_group_path are required
but they were not validated (-native_log_file_path) and validated too
late in a provider (-native_log_zk_group_path) to provide useful
failure messages. Correct this and make the arguments required in
the arg parsing phase.
src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
Diffs
-----
src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 906b3494ab35e70397927ec13f3d9a814059575c
Diff: https://reviews.apache.org/r/42375/diff/
Testing (updated)
-------
```
./gradlew clean distZip
unzip -qd /tmp/ dist/distributions/aurora-scheduler-0.12.0-SNAPSHOT.zip
/tmp/aurora-scheduler-0.12.0-SNAPSHOT/bin/aurora-scheduler
...
I0115 20:18:37.890 [main, ArgScanner:443] zk_in_proc (org.apache.aurora.scheduler.zookeeper.guice.client.flagged.FlaggedClientConfig.zk_in_proc): false
I0115 20:18:37.890 [main, ArgScanner:443] zk_session_timeout (org.apache.aurora.scheduler.zookeeper.guice.client.flagged.FlaggedClientConfig.zk_session_timeout): (4, secs)
I0115 20:18:37.890 [main, ArgScanner:445] -------------------------------------------------------------------------
Exception in thread "main" java.lang.IllegalStateException: A value for the -native_log_file_path flag must be supplied
at org.apache.aurora.scheduler.log.mesos.MesosLogStreamModule.getRequiredArg(MesosLogStreamModule.java:99)
at org.apache.aurora.scheduler.log.mesos.MesosLogStreamModule.<init>(MesosLogStreamModule.java:110)
at org.apache.aurora.scheduler.app.SchedulerMain.main(SchedulerMain.java:209)
```
Thanks,
John Sirois
Re: Review Request 42375: Make required mesos log args required.
Posted by John Sirois <js...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42375/
-----------------------------------------------------------
(Updated Jan. 15, 2016, 8:35 p.m.)
Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
Changes
-------
Fail faster in MesosLogStreamModule.
Fail in the MesosLogStreamModule when required arguments are missing.
Ideally all flag based arguments would be passed via the module
constructor, but a forthcoming change to the argument system will
be doing that work, so this change restricts scope to just the 2
required args.
src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java | 31 +++++++++++++++++++++++--------
1 file changed, 23 insertions(+), 8 deletions(-)
Bugs: AURORA-1587
https://issues.apache.org/jira/browse/AURORA-1587
Repository: aurora
Description
-------
Both -native_log_file_path and -native_log_zk_group_path are required
but they were not validated (-native_log_file_path) and validated too
late in a provider (-native_log_zk_group_path) to provide useful
failure messages. Correct this and make the arguments required in
the arg parsing phase.
src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 906b3494ab35e70397927ec13f3d9a814059575c
Diff: https://reviews.apache.org/r/42375/diff/
Testing
-------
```
./gradlew clean distZip
unzip -qd /tmp/ dist/distributions/aurora-scheduler-0.12.0-SNAPSHOT.zip
/tmp/aurora-scheduler-0.12.0-SNAPSHOT/bin/aurora-scheduler
...
-zk_session_timeout=(4, secs)
The ZooKeeper session timeout.
(org.apache.aurora.scheduler.zookeeper.guice.client.flagged.FlaggedClientConfig.zk_session_timeout)
-------------------------------------------------------------------------
E0115 17:39:48.671 [main, SchedulerMain:217] Failed to apply arguments
java.lang.IllegalArgumentException: Value did not meet constraints:
native_log_zk_group_path - Value must not be null.
mesos_master_address - Value must not be null.
backup_dir - Value must not be null.
serverset_path - Value must not be null.
cluster_name - Value must not be null.
native_log_file_path - Value must not be null.
java.lang.IllegalArgumentException: Value did not meet constraints:
native_log_zk_group_path - Value must not be null.
mesos_master_address - Value must not be null.
backup_dir - Value must not be null.
serverset_path - Value must not be null.
cluster_name - Value must not be null.
native_log_file_path - Value must not be null.
at org.apache.aurora.common.args.ArgScanner.process(ArgScanner.java:437) ~[commons-0.12.0-SNAPSHOT.jar:na]
at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:212) ~[commons-0.12.0-SNAPSHOT.jar:na]
at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:190) ~[commons-0.12.0-SNAPSHOT.jar:na]
at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:167) ~[commons-0.12.0-SNAPSHOT.jar:na]
at org.apache.aurora.scheduler.app.SchedulerMain.applyStaticArgumentValues(SchedulerMain.java:230) [aurora-0.12.0-SNAPSHOT.jar:na]
at org.apache.aurora.scheduler.app.SchedulerMain.main(SchedulerMain.java:203) [aurora-0.12.0-SNAPSHOT.jar:na]
```
Thanks,
John Sirois
Re: Review Request 42375: Make required mesos log args required.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42375/#review114826
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Jan. 15, 2016, 4:40 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42375/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2016, 4:40 p.m.)
>
>
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
>
>
> Bugs: AURORA-1587
> https://issues.apache.org/jira/browse/AURORA-1587
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Both -native_log_file_path and -native_log_zk_group_path are required
> but they were not validated (-native_log_file_path) and validated too
> late in a provider (-native_log_zk_group_path) to provide useful
> failure messages. Correct this and make the arguments required in
> the arg parsing phase.
>
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 906b3494ab35e70397927ec13f3d9a814059575c
>
> Diff: https://reviews.apache.org/r/42375/diff/
>
>
> Testing
> -------
>
> ```
> ./gradlew clean distZip
> unzip -qd /tmp/ dist/distributions/aurora-scheduler-0.12.0-SNAPSHOT.zip
> /tmp/aurora-scheduler-0.12.0-SNAPSHOT/bin/aurora-scheduler
> ...
> -zk_session_timeout=(4, secs)
> The ZooKeeper session timeout.
> (org.apache.aurora.scheduler.zookeeper.guice.client.flagged.FlaggedClientConfig.zk_session_timeout)
> -------------------------------------------------------------------------
> E0115 17:39:48.671 [main, SchedulerMain:217] Failed to apply arguments
> java.lang.IllegalArgumentException: Value did not meet constraints:
> native_log_zk_group_path - Value must not be null.
> mesos_master_address - Value must not be null.
> backup_dir - Value must not be null.
> serverset_path - Value must not be null.
> cluster_name - Value must not be null.
> native_log_file_path - Value must not be null.
> java.lang.IllegalArgumentException: Value did not meet constraints:
> native_log_zk_group_path - Value must not be null.
> mesos_master_address - Value must not be null.
> backup_dir - Value must not be null.
> serverset_path - Value must not be null.
> cluster_name - Value must not be null.
> native_log_file_path - Value must not be null.
>
> at org.apache.aurora.common.args.ArgScanner.process(ArgScanner.java:437) ~[commons-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:212) ~[commons-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:190) ~[commons-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:167) ~[commons-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.scheduler.app.SchedulerMain.applyStaticArgumentValues(SchedulerMain.java:230) [aurora-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.scheduler.app.SchedulerMain.main(SchedulerMain.java:203) [aurora-0.12.0-SNAPSHOT.jar:na]
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42375: Make required mesos log args required.
Posted by Bill Farner <wf...@apache.org>.
> On Jan. 15, 2016, 5:09 p.m., Bill Farner wrote:
> > I believe this will break invocation of the application that don't use the replicated log, for example `./gradlew run`.
>
> John Sirois wrote:
> Yes - thanks for pointing out `./gradlew run`. This is a bit of a nasty situation that would ideally be solved with different binary targets / finer grained gradle modules, but I can patch around this in the constructor for now. The new args system will provide relief w/o having to break up modules iiuc.
>
> New diff coming.
Precisely, new args system will help here.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42375/#review114823
-----------------------------------------------------------
On Jan. 15, 2016, 4:40 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42375/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2016, 4:40 p.m.)
>
>
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
>
>
> Bugs: AURORA-1587
> https://issues.apache.org/jira/browse/AURORA-1587
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Both -native_log_file_path and -native_log_zk_group_path are required
> but they were not validated (-native_log_file_path) and validated too
> late in a provider (-native_log_zk_group_path) to provide useful
> failure messages. Correct this and make the arguments required in
> the arg parsing phase.
>
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 906b3494ab35e70397927ec13f3d9a814059575c
>
> Diff: https://reviews.apache.org/r/42375/diff/
>
>
> Testing
> -------
>
> ```
> ./gradlew clean distZip
> unzip -qd /tmp/ dist/distributions/aurora-scheduler-0.12.0-SNAPSHOT.zip
> /tmp/aurora-scheduler-0.12.0-SNAPSHOT/bin/aurora-scheduler
> ...
> -zk_session_timeout=(4, secs)
> The ZooKeeper session timeout.
> (org.apache.aurora.scheduler.zookeeper.guice.client.flagged.FlaggedClientConfig.zk_session_timeout)
> -------------------------------------------------------------------------
> E0115 17:39:48.671 [main, SchedulerMain:217] Failed to apply arguments
> java.lang.IllegalArgumentException: Value did not meet constraints:
> native_log_zk_group_path - Value must not be null.
> mesos_master_address - Value must not be null.
> backup_dir - Value must not be null.
> serverset_path - Value must not be null.
> cluster_name - Value must not be null.
> native_log_file_path - Value must not be null.
> java.lang.IllegalArgumentException: Value did not meet constraints:
> native_log_zk_group_path - Value must not be null.
> mesos_master_address - Value must not be null.
> backup_dir - Value must not be null.
> serverset_path - Value must not be null.
> cluster_name - Value must not be null.
> native_log_file_path - Value must not be null.
>
> at org.apache.aurora.common.args.ArgScanner.process(ArgScanner.java:437) ~[commons-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:212) ~[commons-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:190) ~[commons-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:167) ~[commons-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.scheduler.app.SchedulerMain.applyStaticArgumentValues(SchedulerMain.java:230) [aurora-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.scheduler.app.SchedulerMain.main(SchedulerMain.java:203) [aurora-0.12.0-SNAPSHOT.jar:na]
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42375: Make required mesos log args required.
Posted by John Sirois <js...@apache.org>.
> On Jan. 15, 2016, 6:09 p.m., Bill Farner wrote:
> > I believe this will break invocation of the application that don't use the replicated log, for example `./gradlew run`.
Yes - thanks for pointing out `./gradlew run`. This is a bit of a nasty situation that would ideally be solved with different binary targets / finer grained gradle modules, but I can patch around this in the constructor for now. The new args system will provide relief w/o having to break up modules iiuc.
New diff coming.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42375/#review114823
-----------------------------------------------------------
On Jan. 15, 2016, 5:40 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42375/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2016, 5:40 p.m.)
>
>
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
>
>
> Bugs: AURORA-1587
> https://issues.apache.org/jira/browse/AURORA-1587
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Both -native_log_file_path and -native_log_zk_group_path are required
> but they were not validated (-native_log_file_path) and validated too
> late in a provider (-native_log_zk_group_path) to provide useful
> failure messages. Correct this and make the arguments required in
> the arg parsing phase.
>
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 906b3494ab35e70397927ec13f3d9a814059575c
>
> Diff: https://reviews.apache.org/r/42375/diff/
>
>
> Testing
> -------
>
> ```
> ./gradlew clean distZip
> unzip -qd /tmp/ dist/distributions/aurora-scheduler-0.12.0-SNAPSHOT.zip
> /tmp/aurora-scheduler-0.12.0-SNAPSHOT/bin/aurora-scheduler
> ...
> -zk_session_timeout=(4, secs)
> The ZooKeeper session timeout.
> (org.apache.aurora.scheduler.zookeeper.guice.client.flagged.FlaggedClientConfig.zk_session_timeout)
> -------------------------------------------------------------------------
> E0115 17:39:48.671 [main, SchedulerMain:217] Failed to apply arguments
> java.lang.IllegalArgumentException: Value did not meet constraints:
> native_log_zk_group_path - Value must not be null.
> mesos_master_address - Value must not be null.
> backup_dir - Value must not be null.
> serverset_path - Value must not be null.
> cluster_name - Value must not be null.
> native_log_file_path - Value must not be null.
> java.lang.IllegalArgumentException: Value did not meet constraints:
> native_log_zk_group_path - Value must not be null.
> mesos_master_address - Value must not be null.
> backup_dir - Value must not be null.
> serverset_path - Value must not be null.
> cluster_name - Value must not be null.
> native_log_file_path - Value must not be null.
>
> at org.apache.aurora.common.args.ArgScanner.process(ArgScanner.java:437) ~[commons-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:212) ~[commons-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:190) ~[commons-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:167) ~[commons-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.scheduler.app.SchedulerMain.applyStaticArgumentValues(SchedulerMain.java:230) [aurora-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.scheduler.app.SchedulerMain.main(SchedulerMain.java:203) [aurora-0.12.0-SNAPSHOT.jar:na]
> ```
>
>
> Thanks,
>
> John Sirois
>
>
Re: Review Request 42375: Make required mesos log args required.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42375/#review114823
-----------------------------------------------------------
I believe this will break invocation of the application that don't use the replicated log, for example `./gradlew run`.
- Bill Farner
On Jan. 15, 2016, 4:40 p.m., John Sirois wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42375/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2016, 4:40 p.m.)
>
>
> Review request for Aurora, Dmitriy Shirchenko and Zameer Manji.
>
>
> Bugs: AURORA-1587
> https://issues.apache.org/jira/browse/AURORA-1587
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Both -native_log_file_path and -native_log_zk_group_path are required
> but they were not validated (-native_log_file_path) and validated too
> late in a provider (-native_log_zk_group_path) to provide useful
> failure messages. Correct this and make the arguments required in
> the arg parsing phase.
>
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 906b3494ab35e70397927ec13f3d9a814059575c
>
> Diff: https://reviews.apache.org/r/42375/diff/
>
>
> Testing
> -------
>
> ```
> ./gradlew clean distZip
> unzip -qd /tmp/ dist/distributions/aurora-scheduler-0.12.0-SNAPSHOT.zip
> /tmp/aurora-scheduler-0.12.0-SNAPSHOT/bin/aurora-scheduler
> ...
> -zk_session_timeout=(4, secs)
> The ZooKeeper session timeout.
> (org.apache.aurora.scheduler.zookeeper.guice.client.flagged.FlaggedClientConfig.zk_session_timeout)
> -------------------------------------------------------------------------
> E0115 17:39:48.671 [main, SchedulerMain:217] Failed to apply arguments
> java.lang.IllegalArgumentException: Value did not meet constraints:
> native_log_zk_group_path - Value must not be null.
> mesos_master_address - Value must not be null.
> backup_dir - Value must not be null.
> serverset_path - Value must not be null.
> cluster_name - Value must not be null.
> native_log_file_path - Value must not be null.
> java.lang.IllegalArgumentException: Value did not meet constraints:
> native_log_zk_group_path - Value must not be null.
> mesos_master_address - Value must not be null.
> backup_dir - Value must not be null.
> serverset_path - Value must not be null.
> cluster_name - Value must not be null.
> native_log_file_path - Value must not be null.
>
> at org.apache.aurora.common.args.ArgScanner.process(ArgScanner.java:437) ~[commons-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:212) ~[commons-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:190) ~[commons-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.common.args.ArgScanner.parse(ArgScanner.java:167) ~[commons-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.scheduler.app.SchedulerMain.applyStaticArgumentValues(SchedulerMain.java:230) [aurora-0.12.0-SNAPSHOT.jar:na]
> at org.apache.aurora.scheduler.app.SchedulerMain.main(SchedulerMain.java:203) [aurora-0.12.0-SNAPSHOT.jar:na]
> ```
>
>
> Thanks,
>
> John Sirois
>
>