[jira] [Commented] (AIRFLOW-983) Make trigger rules more explicit regarding success vs skipped

["Dan Davydov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15935420#comment-15935420 ] 

Dan Davydov commented on AIRFLOW-983:
-------------------------------------

It's possible the reason for the change in semantics (which was to fix a bug) is fixed already by https://github.com/apache/incubator-airflow/pull/2154 and the only thing we need to do is revert https://github.com/apache/incubator-airflow/pull/2125]

> Make trigger rules more explicit regarding success vs skipped
> -------------------------------------------------------------
>
>                 Key: AIRFLOW-983
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-983
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: dependencies
>            Reporter: Daniel Huang
>            Priority: Critical
>
> Since AIRFLOW-719, the trigger rules all_success/one_success include both success and skipped states.
> We should probably make ALL_SUCCESS strictly success (again) and add a separate ALL_SUCCESS_OR_SKIPPED/ALL_FAILED_OR_SKIPPED. ALL_SUCCESS_OR_SKIPPED may be a more appropriate default trigger rule as well. Otherwise, we need to note in LatestOnly/ShortCircuit/Branch operators of the appropriate trigger rule to use there.
> Some previous discussion in https://github.com/apache/incubator-airflow/pull/1961
> It's possible the reason for the change in semantics (which was to fix a bug) is fixed already by https://github.com/apache/incubator-airflow/pull/2154 and the only thing we need to do is revert https://github.com/apache/incubator-airflow/pull/2125



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)