You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "domoritz (via GitHub)" <gi...@apache.org> on 2023/03/14 22:23:18 UTC
[GitHub] [arrow] domoritz opened a new issue, #34567: Remove bin/bin directory from bundles
domoritz opened a new issue, #34567:
URL: https://github.com/apache/arrow/issues/34567
### Describe the bug, including details regarding any error messages, version, and platform.
The generated bundles contain a /bin/bin directory that should not be there.
<img width="244" alt="Screenshot 2023-03-14 at 18 23 03" src="https://user-images.githubusercontent.com/589034/225155558-097beb01-2dc8-4a12-afa4-e80cb4202150.png">
### Component(s)
JavaScript
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on issue #34567: [JS] Remove bin/bin directory from bundles
Posted by "domoritz (via GitHub)" <gi...@apache.org>.
domoritz commented on issue #34567:
URL: https://github.com/apache/arrow/issues/34567#issuecomment-1614966284
No rush. Go for it! It should be easy to see whether you succeeded by checking the bundles generated by `npm pack`. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abetomo commented on issue #34567: [JS] Remove bin/bin directory from bundles
Posted by "abetomo (via GitHub)" <gi...@apache.org>.
abetomo commented on issue #34567:
URL: https://github.com/apache/arrow/issues/34567#issuecomment-1614192286
Is it a problem you need solved in a hurry?
May I work on it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abetomo commented on issue #34567: [JS] Remove bin/bin directory from bundles
Posted by "abetomo (via GitHub)" <gi...@apache.org>.
abetomo commented on issue #34567:
URL: https://github.com/apache/arrow/issues/34567#issuecomment-1620818266
Is it correct that the following files generated under `targets` should not exist?
```
targets/apache-arrow/bin/bin/arrow2csv.js
targets/apache-arrow/bin/bin/arrow2csv.js.map
targets/apache-arrow/bin/bin/arrow2csv.mjs
targets/apache-arrow/bin/src/bin/arrow2csv.ts
targets/es2015/cjs/bin/bin/arrow2csv.js
targets/es2015/cjs/bin/bin/arrow2csv.js.map
targets/es2015/cjs/bin/src/bin/arrow2csv.ts
targets/es2015/esm/bin/bin/arrow2csv.js
targets/es2015/esm/bin/bin/arrow2csv.js.map
targets/es2015/esm/bin/src/bin/arrow2csv.ts
targets/es2015/umd/bin/bin/arrow2csv.js
targets/es2015/umd/bin/bin/arrow2csv.js.map
targets/es2015/umd/bin/src/bin/arrow2csv.ts
targets/es5/cjs/bin/bin/arrow2csv.js
targets/es5/cjs/bin/bin/arrow2csv.js.map
targets/es5/cjs/bin/src/bin/arrow2csv.ts
targets/es5/esm/bin/bin/arrow2csv.js
targets/es5/esm/bin/bin/arrow2csv.js.map
targets/es5/esm/bin/src/bin/arrow2csv.ts
targets/es5/umd/bin/bin/arrow2csv.js
targets/es5/umd/bin/bin/arrow2csv.js.map
targets/es5/umd/bin/src/bin/arrow2csv.ts
targets/esnext/cjs/bin/bin/arrow2csv.js
targets/esnext/cjs/bin/bin/arrow2csv.js.map
targets/esnext/cjs/bin/src/bin/arrow2csv.ts
targets/esnext/esm/bin/bin/arrow2csv.js
targets/esnext/esm/bin/bin/arrow2csv.js.map
targets/esnext/esm/bin/src/bin/arrow2csv.ts
targets/esnext/umd/bin/bin/arrow2csv.js
targets/esnext/umd/bin/bin/arrow2csv.js.map
targets/esnext/umd/bin/src/bin/arrow2csv.ts
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on issue #34567: [JS] Remove bin/bin directory from bundles
Posted by "domoritz (via GitHub)" <gi...@apache.org>.
domoritz commented on issue #34567:
URL: https://github.com/apache/arrow/issues/34567#issuecomment-1620830392
I think so, yes. We should make sure the scripts still work and that the sources are still in a location where the editor can give you correct sources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abetomo commented on issue #34567: [JS] Remove bin/bin directory from bundles
Posted by "abetomo (via GitHub)" <gi...@apache.org>.
abetomo commented on issue #34567:
URL: https://github.com/apache/arrow/issues/34567#issuecomment-1614001985
I haven't looked into it in detail, but the following patch may improve it.
```diff
--- a/js/gulp/typescript-task.js
+++ b/js/gulp/typescript-task.js
@@ -34,7 +34,6 @@ export const typescriptTask = ((cache) => memoizeTask(cache, function typescript
const out = targetDir(target, format);
const tsconfigPath = path.join(`tsconfig`, `tsconfig.${tsconfigName(target, format)}.json`);
return compileTypescript(out, tsconfigPath)
- .pipe(mergeWith(compileBinFiles(target, format)))
.pipe(takeLast(1))
.pipe(share({ connector: () => new ReplaySubject(), resetOnError: false, resetOnComplete: false, resetOnRefCountZero: false }))
}))({});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abetomo commented on issue #34567: [JS] Remove bin/bin directory from bundles
Posted by "abetomo (via GitHub)" <gi...@apache.org>.
abetomo commented on issue #34567:
URL: https://github.com/apache/arrow/issues/34567#issuecomment-1615282624
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz closed issue #34567: [JS] Remove bin/bin directory from bundles
Posted by "domoritz (via GitHub)" <gi...@apache.org>.
domoritz closed issue #34567: [JS] Remove bin/bin directory from bundles
URL: https://github.com/apache/arrow/issues/34567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on issue #34567: [JS] Remove bin/bin directory from bundles
Posted by "domoritz (via GitHub)" <gi...@apache.org>.
domoritz commented on issue #34567:
URL: https://github.com/apache/arrow/issues/34567#issuecomment-1614114296
We will need to check carefully since we want the bin files themselves included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abetomo commented on issue #34567: [JS] Remove bin/bin directory from bundles
Posted by "abetomo (via GitHub)" <gi...@apache.org>.
abetomo commented on issue #34567:
URL: https://github.com/apache/arrow/issues/34567#issuecomment-1629937356
https://github.com/apache/arrow/commit/5598d2f42573ed19e7db4aae7adb02af2cd4ccd0#diff-cef18da59d581d0c92a1e262b6e7de2afac26d08cfa38fd8917f12fa9c48960fL2-R2
`js/tsconfig/tsconfig.base.json`
```diff
- "exclude": ["../node_modules", "../src/bin/*.ts"],
+ "exclude": ["../node_modules"],
```
This change seems to generate `bin` without `compileBinFiles`(https://github.com/apache/arrow/issues/34567#issuecomment-1614001985).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] abetomo commented on issue #34567: [JS] Remove bin/bin directory from bundles
Posted by "abetomo (via GitHub)" <gi...@apache.org>.
abetomo commented on issue #34567:
URL: https://github.com/apache/arrow/issues/34567#issuecomment-1615282596
Thanks for the reply!
I got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org