You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "claudio4j (via GitHub)" <gi...@apache.org> on 2023/05/18 03:04:04 UTC
[GitHub] [camel-k] claudio4j opened a new pull request, #4391: Fix e2e/namespace/install/cli/run_test.go for cli run from gist
claudio4j opened a new pull request, #4391:
URL: https://github.com/apache/camel-k/pull/4391
Fix https://github.com/apache/camel-k/issues/3952
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #4391: Fix e2e/namespace/install/cli/run_test.go for cli run from gist
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on PR #4391:
URL: https://github.com/apache/camel-k/pull/4391#issuecomment-1554175274
It seems this is affected by #4358 - merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez merged pull request #4391: Fix e2e/namespace/install/cli/run_test.go for cli run from gist
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez merged PR #4391:
URL: https://github.com/apache/camel-k/pull/4391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on a diff in pull request #4391: Fix e2e/namespace/install/cli/run_test.go for cli run from gist
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on code in PR #4391:
URL: https://github.com/apache/camel-k/pull/4391#discussion_r1197498308
##########
e2e/namespace/install/cli/run_test.go:
##########
@@ -75,6 +75,10 @@ func TestKamelCLIRun(t *testing.T) {
Expect(Kamel("delete", "--all", "-n", ns).Execute()).To(Succeed())
})
+ // GIST does not like GITHUB_TOKEN apparently, we must temporary remove it
+ os.Setenv("GITHUB_TOKEN_TMP", os.Getenv("GITHUB_TOKEN"))
Review Comment:
You've missed the import statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org