You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by kushalsaha <gi...@git.apache.org> on 2017/09/06 09:08:48 UTC
[GitHub] carbondata pull request #1331: [CARBONDATA-1326][WIP]: Normal/Low priority f...
GitHub user kushalsaha opened a pull request:
https://github.com/apache/carbondata/pull/1331
[CARBONDATA-1326][WIP]: Normal/Low priority findbug fixes
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[CARBONDATA-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- What manual testing you have done?
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kushalsaha/carbondata CRABONDATA-1326
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1331.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1331
----
commit bc2709c83762f021390608ac6029bae91d1e75d5
Author: kushalsaha <ku...@gmail.com>
Date: 2017-09-06T08:56:50Z
[CARBONDATA-1326][WIP]: Normal/Low priority findbug fixes
----
---
[GitHub] carbondata issue #1331: [CARBONDATA-1326][WIP]: Normal/Low priority findbug ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1331
Can one of the admins verify this patch?
---
[GitHub] carbondata pull request #1331: [CARBONDATA-1326][WIP]: Normal/Low priority f...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1331#discussion_r137282769
--- Diff: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerColumnar.java ---
@@ -21,13 +21,7 @@
import java.io.IOException;
import java.util.ArrayList;
import java.util.List;
-import java.util.concurrent.Callable;
-import java.util.concurrent.ExecutionException;
-import java.util.concurrent.ExecutorService;
-import java.util.concurrent.Executors;
-import java.util.concurrent.Future;
-import java.util.concurrent.Semaphore;
-import java.util.concurrent.TimeUnit;
+import java.util.concurrent.*;
--- End diff --
do not use *
---
[GitHub] carbondata issue #1331: [CARBONDATA-1326][WIP]: Normal/Low priority findbug ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1331
Can one of the admins verify this patch?
---
[GitHub] carbondata pull request #1331: [CARBONDATA-1326][WIP]: Normal/Low priority f...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1331#discussion_r137282685
--- Diff: processing/src/main/java/org/apache/carbondata/processing/sortandgroupby/sortdata/SortParameters.java ---
@@ -34,6 +34,8 @@
public class SortParameters implements Serializable {
+ private static final long serialVersionUID = 0L;
--- End diff --
serialVersionUID should not be 0L
---
[GitHub] carbondata pull request #1331: [CARBONDATA-1326][WIP]: Normal/Low priority f...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1331#discussion_r137282962
--- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/CarbonDataWriterVo.java ---
@@ -155,14 +155,14 @@ public void setIsComplexType(boolean[] isComplexType) {
* @return the noDictionaryCount
*/
public int getNoDictionaryCount() {
- return NoDictionaryCount;
+ return noDictionaryCount;
}
/**
- * @param noDictionaryCount the noDictionaryCount to set
+ * @param no_DictionaryCount the noDictionaryCount to set
*/
- public void setNoDictionaryCount(int noDictionaryCount) {
- NoDictionaryCount = noDictionaryCount;
+ public void setNoDictionaryCount(int no_DictionaryCount) {
--- End diff --
No need to change this
---
[GitHub] carbondata pull request #1331: [CARBONDATA-1326][WIP]: Normal/Low priority f...
Posted by kushalsaha <gi...@git.apache.org>.
Github user kushalsaha closed the pull request at:
https://github.com/apache/carbondata/pull/1331
---