You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/05/03 10:00:05 UTC
[GitHub] [ignite] ptupitsyn commented on a change in pull request #7765: IGNITE-12937: Add pull request github template
ptupitsyn commented on a change in pull request #7765:
URL: https://github.com/apache/ignite/pull/7765#discussion_r419078923
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,25 @@
+Thank you for submitting the pull request to the Apache Ignite.
+
+In order to streamline the review of the contribution
+we ask you to ensure the following steps have been taken:
+
+### The Contribution Checklist
+- [ ] The JIRA ticket has been associated with the pull request
Review comment:
Associated how?
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,25 @@
+Thank you for submitting the pull request to the Apache Ignite.
+
+In order to streamline the review of the contribution
+we ask you to ensure the following steps have been taken:
+
+### The Contribution Checklist
+- [ ] The JIRA ticket has been associated with the pull request
+- [ ] The JIRA ticket has the _Patch Available_ state
+- [ ] The pull request briefly describes changes that have been made
+- [ ] The pull request title has the following pattern
+e.g. `IGNITE-12407: Java thin client. Cluster API support`
+- [ ] Commits have the following pattern
Review comment:
In my opinion, this should not be a requirement. We merge with squash, why waste time on intermediate commits? There can be hundreds of them with review fixes, test tweaks, and so on.
##########
File path: .github/PULL_REQUEST_TEMPLATE.md
##########
@@ -0,0 +1,25 @@
+Thank you for submitting the pull request to the Apache Ignite.
+
+In order to streamline the review of the contribution
+we ask you to ensure the following steps have been taken:
+
+### The Contribution Checklist
+- [ ] The JIRA ticket has been associated with the pull request
+- [ ] The JIRA ticket has the _Patch Available_ state
+- [ ] The pull request briefly describes changes that have been made
+- [ ] The pull request title has the following pattern
+e.g. `IGNITE-12407: Java thin client. Cluster API support`
Review comment:
I think we should provide a detailed commit message guide on Ignite Wiki, and add a link here.
Lots of good guidance here: https://chris.beams.io/posts/git-commit/
PR title and description should be used for the final squashed commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org