You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@phoenix.apache.org by ra...@apache.org on 2023/12/04 17:05:03 UTC
(phoenix-omid) branch master updated: OMID-240 Transactional visibility is broken (#149)
This is an automated email from the ASF dual-hosted git repository.
rajeshbabu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/phoenix-omid.git
The following commit(s) were added to refs/heads/master by this push:
new a1f1fbe8 OMID-240 Transactional visibility is broken (#149)
a1f1fbe8 is described below
commit a1f1fbe8c7c03ef8c52afdd40a8e81b5748c0c16
Author: Rajeshbabu Chintaguntla <ch...@gmail.com>
AuthorDate: Mon Dec 4 22:34:57 2023 +0530
OMID-240 Transactional visibility is broken (#149)
* OMID-240 Transactional visibility is broken
with InMemoryCommitTableStorageModule by default server side filtering not working properly.
So changing it to HBase Commit Table Storage Module
* Check and set hadoop and hbase configuration directories
---------
Co-authored-by: Rajeshbabu Chintaguntla <ra...@apache.org>
---
tso-server/bin/omid-env.sh | 16 ++++++++++++++--
.../main/resources/default-omid-server-configuration.yml | 2 +-
2 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/tso-server/bin/omid-env.sh b/tso-server/bin/omid-env.sh
index 578382ce..80c53471 100644
--- a/tso-server/bin/omid-env.sh
+++ b/tso-server/bin/omid-env.sh
@@ -22,6 +22,18 @@
# Check if HADOOP_CONF_DIR and HBASE_CONF_DIR are set
# ---------------------------------------------------------------------------------------------------------------------
-if [ -z ${HADOOP_CONF_DIR+x} ]; then echo "WARNING: HADOOP_CONF_DIR is unset"; else echo "HADOOP_CONF_DIR is set to '$HADOOP_CONF_DIR'"; fi
-if [ -z ${HBASE_CONF_DIR+x} ]; then echo "WARNING: HBASE_CONF_DIR is unset"; else echo "HBASE_CONF_DIR is set to '$HBASE_CONF_DIR'"; fi
+if [ -z ${HADOOP_CONF_DIR+x} ];
+ then echo "WARNING: HADOOP_CONF_DIR is unset";
+ if [ -d "/etc/hadoop/conf" ]; then
+ HADOOP_CONF_DIR=/etc/hadoop/conf
+ echo "Setting to ${HADOOP_CONF_DIR}"
+ fi
+else echo "HADOOP_CONF_DIR is set to '$HADOOP_CONF_DIR'"; fi
+if [ -z ${HBASE_CONF_DIR+x} ];
+ then echo "WARNING: HBASE_CONF_DIR is unset";
+ if [ -f "/etc/hbase/conf/hbase-site.xml" ]; then
+ HBASE_CONF_DIR=/etc/hbase/conf
+ echo "Setting to ${HBASE_CONF_DIR}"
+ fi
+else echo "HBASE_CONF_DIR is set to '$HBASE_CONF_DIR'"; fi
diff --git a/tso-server/src/main/resources/default-omid-server-configuration.yml b/tso-server/src/main/resources/default-omid-server-configuration.yml
index 0e065a00..10448012 100644
--- a/tso-server/src/main/resources/default-omid-server-configuration.yml
+++ b/tso-server/src/main/resources/default-omid-server-configuration.yml
@@ -47,7 +47,7 @@ timestampType: WORLD_TIME
lowLatency: false
# Default module configuration (No TSO High Availability & in-memory storage for timestamp and commit tables)
timestampStoreModule: !!org.apache.omid.tso.InMemoryTimestampStorageModule [ ]
-commitTableStoreModule: !!org.apache.omid.tso.InMemoryCommitTableStorageModule [ ]
+commitTableStoreModule: !!org.apache.omid.committable.hbase.DefaultHBaseCommitTableStorageModule [ ]
leaseModule: !!org.apache.omid.tso.VoidLeaseManagementModule [ ]
# Default stats/metrics configuration