You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@guacamole.apache.org by "Bradley Bennett (Jira)" <ji...@apache.org> on 2026/04/02 16:28:00 UTC

[jira] [Created] (GUACAMOLE-2255) Fix intermittent RDP error handling due to uninitialized variable

Bradley Bennett created GUACAMOLE-2255:
------------------------------------------

             Summary: Fix intermittent RDP error handling due to uninitialized variable
                 Key: GUACAMOLE-2255
                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-2255
             Project: Guacamole
          Issue Type: Bug
          Components: guacd
    Affects Versions: 1.6.1 [staging]
            Reporter: Bradley Bennett
             Fix For: 1.6.1 [staging]


 The `connection_closing` variable in `rdp.c` (line 627) is not initialized before use. When RDP event handling fails early in the do-while loop, the code breaks before `connection_closing` is assigned a value, leading to potentially aborting a RDP connection because of an error without report the closing as an error.    

This was caused by a fix for  GUACAMOLE-2221 (fix RDP busy-loop on transport failure) which added a break.

I cam across this build Guacamole on Rocky 9.

{code:java}
rdp.c: In function 'guac_rdp_client_thread':
rdp.c:658:12: error: 'connection_closing' may be used uninitialized in this function [-Werror=maybe-uninitialized]
  658 |         if (connection_closing)
      |            ^
rdp.c:627:13: note: 'connection_closing' was declared here
  627 |         int connection_closing;
      |             ^~~~~~~~~~~~~~~~~~
{code}




--
This message was sent by Atlassian Jira
(v8.20.10#820010)