You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Li Jing Qin (JIRA)" <ji...@apache.org> on 2010/03/11 09:58:27 UTC
[jira] Created: (HARMONY-6465) [classlib][nio]Small fixes according
to the findbug results
[classlib][nio]Small fixes according to the findbug results
-----------------------------------------------------------
Key: HARMONY-6465
URL: https://issues.apache.org/jira/browse/HARMONY-6465
Project: Harmony
Issue Type: Bug
Components: Classlib
Environment: All
Reporter: Li Jing Qin
Priority: Minor
Fix For: 5.0M14
According to the findbug results, this patch including simple fixes or refactors as follow:
1. Use Integer.valueOf instead of new Integer, which may use the Integer cached. (MappedByteBufferFactory.java)
2. Use the primitive 0L instead of the new Long(0). (SocketChannelImpl.java)
3. Change the final int to be a static field. (EpollSelectorImpl.java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-6465) [classlib][nio]Small fixes
according to the findbug results
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison reassigned HARMONY-6465:
------------------------------------
Assignee: Tim Ellison
> [classlib][nio]Small fixes according to the findbug results
> -----------------------------------------------------------
>
> Key: HARMONY-6465
> URL: https://issues.apache.org/jira/browse/HARMONY-6465
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: All
> Reporter: Li Jing Qin
> Assignee: Tim Ellison
> Priority: Minor
> Fix For: 5.0M14
>
> Attachments: findbug-nio.diff, findbug-nio.diff
>
>
> According to the findbug results, this patch including simple fixes or refactors as follow:
> 1. Use Integer.valueOf instead of new Integer, which may use the Integer cached. (MappedByteBufferFactory.java)
> 2. Use the primitive 0L instead of the new Long(0). (SocketChannelImpl.java)
> 3. Change the final int to be a static field. (EpollSelectorImpl.java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-6465) [classlib][nio]Small fixes
according to the findbug results
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim Ellison resolved HARMONY-6465.
----------------------------------
Resolution: Fixed
> [classlib][nio]Small fixes according to the findbug results
> -----------------------------------------------------------
>
> Key: HARMONY-6465
> URL: https://issues.apache.org/jira/browse/HARMONY-6465
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: All
> Reporter: Li Jing Qin
> Assignee: Tim Ellison
> Priority: Minor
> Fix For: 5.0M14
>
> Attachments: findbug-nio.diff, findbug-nio.diff
>
>
> According to the findbug results, this patch including simple fixes or refactors as follow:
> 1. Use Integer.valueOf instead of new Integer, which may use the Integer cached. (MappedByteBufferFactory.java)
> 2. Use the primitive 0L instead of the new Long(0). (SocketChannelImpl.java)
> 3. Change the final int to be a static field. (EpollSelectorImpl.java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6465) [classlib][nio]Small fixes according
to the findbug results
Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Jing Qin updated HARMONY-6465:
---------------------------------
Attachment: findbug-nio.diff
Would anyone want to try this?
> [classlib][nio]Small fixes according to the findbug results
> -----------------------------------------------------------
>
> Key: HARMONY-6465
> URL: https://issues.apache.org/jira/browse/HARMONY-6465
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: All
> Reporter: Li Jing Qin
> Priority: Minor
> Fix For: 5.0M14
>
> Attachments: findbug-nio.diff
>
>
> According to the findbug results, this patch including simple fixes or refactors as follow:
> 1. Use Integer.valueOf instead of new Integer, which may use the Integer cached. (MappedByteBufferFactory.java)
> 2. Use the primitive 0L instead of the new Long(0). (SocketChannelImpl.java)
> 3. Change the final int to be a static field. (EpollSelectorImpl.java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-6465) [classlib][nio]Small fixes according
to the findbug results
Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Jing Qin closed HARMONY-6465.
--------------------------------
Estimated Complexity: Novice
Verified. Thanks Tim.
> [classlib][nio]Small fixes according to the findbug results
> -----------------------------------------------------------
>
> Key: HARMONY-6465
> URL: https://issues.apache.org/jira/browse/HARMONY-6465
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: All
> Reporter: Li Jing Qin
> Assignee: Tim Ellison
> Priority: Minor
> Fix For: 5.0M14
>
> Attachments: findbug-nio.diff, findbug-nio.diff
>
>
> According to the findbug results, this patch including simple fixes or refactors as follow:
> 1. Use Integer.valueOf instead of new Integer, which may use the Integer cached. (MappedByteBufferFactory.java)
> 2. Use the primitive 0L instead of the new Long(0). (SocketChannelImpl.java)
> 3. Change the final int to be a static field. (EpollSelectorImpl.java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6465) [classlib][nio]Small fixes according
to the findbug results
Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Li Jing Qin updated HARMONY-6465:
---------------------------------
Attachment: findbug-nio.diff
According to the comments of SocketChannelImpl, which said the long value must be newed not valueOf. I have removed the diff part of SocketChannelImpl.
> [classlib][nio]Small fixes according to the findbug results
> -----------------------------------------------------------
>
> Key: HARMONY-6465
> URL: https://issues.apache.org/jira/browse/HARMONY-6465
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: All
> Reporter: Li Jing Qin
> Priority: Minor
> Fix For: 5.0M14
>
> Attachments: findbug-nio.diff, findbug-nio.diff
>
>
> According to the findbug results, this patch including simple fixes or refactors as follow:
> 1. Use Integer.valueOf instead of new Integer, which may use the Integer cached. (MappedByteBufferFactory.java)
> 2. Use the primitive 0L instead of the new Long(0). (SocketChannelImpl.java)
> 3. Change the final int to be a static field. (EpollSelectorImpl.java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6465) [classlib][nio]Small fixes
according to the findbug results
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844521#action_12844521 ]
Tim Ellison commented on HARMONY-6465:
--------------------------------------
Thanks Charles, patch applied at repo revision r922278.
Please check it was applied as you expected.
Note that you can add FindBugs exclude filters to nio/make/findbugs-exclude-filter.xml if you determine they are false positives.
> [classlib][nio]Small fixes according to the findbug results
> -----------------------------------------------------------
>
> Key: HARMONY-6465
> URL: https://issues.apache.org/jira/browse/HARMONY-6465
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: All
> Reporter: Li Jing Qin
> Assignee: Tim Ellison
> Priority: Minor
> Fix For: 5.0M14
>
> Attachments: findbug-nio.diff, findbug-nio.diff
>
>
> According to the findbug results, this patch including simple fixes or refactors as follow:
> 1. Use Integer.valueOf instead of new Integer, which may use the Integer cached. (MappedByteBufferFactory.java)
> 2. Use the primitive 0L instead of the new Long(0). (SocketChannelImpl.java)
> 3. Change the final int to be a static field. (EpollSelectorImpl.java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6465) [classlib][nio]Small fixes
according to the findbug results
Posted by "Li Jing Qin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845200#action_12845200 ]
Li Jing Qin commented on HARMONY-6465:
--------------------------------------
I have refresh my code base. It seems the point 2 I have removed has already been excluded. (sigh)
> [classlib][nio]Small fixes according to the findbug results
> -----------------------------------------------------------
>
> Key: HARMONY-6465
> URL: https://issues.apache.org/jira/browse/HARMONY-6465
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Environment: All
> Reporter: Li Jing Qin
> Assignee: Tim Ellison
> Priority: Minor
> Fix For: 5.0M14
>
> Attachments: findbug-nio.diff, findbug-nio.diff
>
>
> According to the findbug results, this patch including simple fixes or refactors as follow:
> 1. Use Integer.valueOf instead of new Integer, which may use the Integer cached. (MappedByteBufferFactory.java)
> 2. Use the primitive 0L instead of the new Long(0). (SocketChannelImpl.java)
> 3. Change the final int to be a static field. (EpollSelectorImpl.java)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.