You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "dominikhei (via GitHub)" <gi...@apache.org> on 2025/05/30 10:51:05 UTC
[PR] Removed unnecessary aws_conn_id param from operators constructors [airflow]
dominikhei opened a new pull request, #51236:
URL: https://github.com/apache/airflow/pull/51236
---
As discussed on #51196 there are some more operators, that set the `aws_conn_id` in their constructor, even though it is set by the base operator from which they inherit. This does not lead to any errors, but is not consistent, which is why I removed it. Feel free to close the PR if you think it's unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed unnecessary aws_conn_id param from operators constructors [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on PR #51236:
URL: https://github.com/apache/airflow/pull/51236#issuecomment-2923424616
Thanks for opening this! I'm still in favour of keeping the doc strings (I replied on the other thread I started that Vincent linked).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed unnecessary aws_conn_id param from operators constructors [airflow]
Posted by "dominikhei (via GitHub)" <gi...@apache.org>.
dominikhei commented on PR #51236:
URL: https://github.com/apache/airflow/pull/51236#issuecomment-2925086650
> Can you add tests for these operators like you did for the RDS case? I know not all of them have it, but it's a great mechanism to ensure we don't regress, so if you're modifying these ops anyway, adding the same tests would be great.
I added them for all the operators I have adjusted before + I have renamed the test: no_conn to default_conn to avoid any misunderstandings in the future. If u want me to add them to other operators etc. lmk!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Removed unnecessary aws_conn_id param from operators constructors [airflow]
Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck merged PR #51236:
URL: https://github.com/apache/airflow/pull/51236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org