You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Michael Dürig (JIRA)" <ji...@apache.org> on 2013/09/24 09:34:03 UTC

[jira] [Commented] (OAK-1037) Improve performance of XmlImport

    [ https://issues.apache.org/jira/browse/OAK-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13776076#comment-13776076 ] 

Michael Dürig commented on OAK-1037:
------------------------------------

bq. The NodeBuilder returned from the call is immutable. It would better to cache the instance until no further change has been made under that subtree.

(Note, this should read NodeState, not NodeBuilder). Re caching: agreed, this would improve the situation quite a bit. But at the same time we should also look into (a) why is that call so expensive and (b) why is this method called so often. 

* There is OAK-1036 for (a) and probably an issue upcoming for related work on the other  based back ends. 

* For (b), AFIK the problem is a non optimal algorithm for resolving UUIDs in the XmlImport code. We should look into ways to resolve all UUIDs only present in transient space in a single sweep instead of having to traverse once per UUID. [~tmueller] came up with some nice ideas here. 
                
> Improve performance of XmlImport
> --------------------------------
>
>                 Key: OAK-1037
>                 URL: https://issues.apache.org/jira/browse/OAK-1037
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: jcr
>    Affects Versions: 0.9
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>         Attachments: jmc-oak-importxml-1.png
>
>
> The XmlImport benchmark [1] is running slow on Oak compared to Jackrabbit on various persistence backends
> {noformat}
> # XmlImportTest                  min     10%     50%     90%     max       N
> Oak-Tar                       277901  277922  282454  288859  289186      10
> Oak-Mongo                     362531  363342  382810  401213  401954      10
> Jackrabbit                     11961   11969   12816   14158   14173      10
> {noformat}
> The performance here needs to be improved
> [1] https://svn.apache.org/repos/asf/jackrabbit/oak/trunk/oak-run/src/main/java/org/apache/jackrabbit/oak/benchmark/XmlImportTest.java

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira