You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2019/10/16 00:44:27 UTC

Review Request 71621: RANGER-2623:Add Validations to RoleREST apis

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71621/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Repository: ranger


Description
-------

RANGER-2623:Add Validations to RoleREST apis


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java 34f41f1 
  agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerRoleValidator.java PRE-CREATION 
  agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java f31483e 
  agents-common/src/main/java/org/apache/ranger/plugin/store/RoleStore.java 8bf4603 
  security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java dfc5be8 
  security-admin/src/main/java/org/apache/ranger/common/RangerValidatorFactory.java 04c941e 
  security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 268c8c4 


Diff: https://reviews.apache.org/r/71621/diff/1/


Testing
-------

Verified in LOCAL by create / update /delete roles via rest api.


Thanks,

Ramesh Mani

Re: Review Request 71621: RANGER-2623:Add Validations to RoleREST apis

Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71621/#review218241
-----------------------------------------------------------




agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerRoleValidator.java
Lines 88 (patched)
<https://reviews.apache.org/r/71621/#comment305876>

    Please review the error message. It needs to be "Role with id={id} does not exist"



agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerRoleValidator.java
Lines 132 (patched)
<https://reviews.apache.org/r/71621/#comment305877>

    Please review the error message as in line 88



agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerRoleValidator.java
Lines 156 (patched)
<https://reviews.apache.org/r/71621/#comment305878>

    There is no field named "RangerRole". Please review the error message.



agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerRoleValidator.java
Lines 182 (patched)
<https://reviews.apache.org/r/71621/#comment305879>

    field == "users and groups and roles"



security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java
Lines 319 (patched)
<https://reviews.apache.org/r/71621/#comment305880>

    Why is detach() necessary ? here and in line 326.


- Abhay Kulkarni


On Oct. 16, 2019, 3:13 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71621/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2019, 3:13 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2623
>     https://issues.apache.org/jira/browse/RANGER-2623
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-2623:Add Validations to RoleREST apis
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java 34f41f1 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerRoleValidator.java PRE-CREATION 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java f31483e 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/RoleStore.java 8bf4603 
>   security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java dfc5be8 
>   security-admin/src/main/java/org/apache/ranger/common/RangerValidatorFactory.java 04c941e 
>   security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 268c8c4 
> 
> 
> Diff: https://reviews.apache.org/r/71621/diff/1/
> 
> 
> Testing
> -------
> 
> Verified in LOCAL by create / update /delete roles via rest api.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Re: Review Request 71621: RANGER-2623:Add Validations to RoleREST apis

Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71621/#review218249
-----------------------------------------------------------


Ship it!




Ship It!

- Abhay Kulkarni


On Oct. 16, 2019, 10:55 p.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71621/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2019, 10:55 p.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2623
>     https://issues.apache.org/jira/browse/RANGER-2623
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-2623:Add Validations to RoleREST apis
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java 34f41f1 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerRoleValidator.java PRE-CREATION 
>   agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java f31483e 
>   agents-common/src/main/java/org/apache/ranger/plugin/store/RoleStore.java 8bf4603 
>   security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java dfc5be8 
>   security-admin/src/main/java/org/apache/ranger/common/RangerValidatorFactory.java 04c941e 
>   security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 268c8c4 
> 
> 
> Diff: https://reviews.apache.org/r/71621/diff/2/
> 
> 
> Testing
> -------
> 
> Verified in LOCAL by create / update /delete roles via rest api.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Re: Review Request 71621: RANGER-2623:Add Validations to RoleREST apis

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71621/
-----------------------------------------------------------

(Updated Oct. 16, 2019, 10:55 p.m.)


Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Changes
-------

Review comments fixed


Bugs: RANGER-2623
    https://issues.apache.org/jira/browse/RANGER-2623


Repository: ranger


Description
-------

RANGER-2623:Add Validations to RoleREST apis


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java 34f41f1 
  agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerRoleValidator.java PRE-CREATION 
  agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java f31483e 
  agents-common/src/main/java/org/apache/ranger/plugin/store/RoleStore.java 8bf4603 
  security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java dfc5be8 
  security-admin/src/main/java/org/apache/ranger/common/RangerValidatorFactory.java 04c941e 
  security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 268c8c4 


Diff: https://reviews.apache.org/r/71621/diff/2/

Changes: https://reviews.apache.org/r/71621/diff/1-2/


Testing
-------

Verified in LOCAL by create / update /delete roles via rest api.


Thanks,

Ramesh Mani

Re: Review Request 71621: RANGER-2623:Add Validations to RoleREST apis

Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71621/
-----------------------------------------------------------

(Updated Oct. 16, 2019, 3:13 p.m.)


Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2623
    https://issues.apache.org/jira/browse/RANGER-2623


Repository: ranger


Description
-------

RANGER-2623:Add Validations to RoleREST apis


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java 34f41f1 
  agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerRoleValidator.java PRE-CREATION 
  agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java f31483e 
  agents-common/src/main/java/org/apache/ranger/plugin/store/RoleStore.java 8bf4603 
  security-admin/src/main/java/org/apache/ranger/biz/RoleDBStore.java dfc5be8 
  security-admin/src/main/java/org/apache/ranger/common/RangerValidatorFactory.java 04c941e 
  security-admin/src/main/java/org/apache/ranger/rest/RoleREST.java 268c8c4 


Diff: https://reviews.apache.org/r/71621/diff/1/


Testing
-------

Verified in LOCAL by create / update /delete roles via rest api.


Thanks,

Ramesh Mani