You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <gi...@mesoshere.io> on 2015/09/30 20:31:17 UTC
Review Request 38901: Serialize Docker Image Spec as Protobuf
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38901/
-----------------------------------------------------------
Review request for mesos, Jojy Varghese and Timothy Chen.
Bugs: MESOS-2972
https://issues.apache.org/jira/browse/MESOS-2972
Repository: mesos
Description
-------
Serialize Docker Image Spec as Protobuf
Diffs
-----
src/Makefile.am 8aa456611dd5405336dd7b0c19ba4a942ea1c805
src/slave/containerizer/provisioner/docker/message.proto bbac2e6c1f40a7ca3f9227baca56a44cd43f58c6
src/slave/containerizer/provisioner/docker/spec.hpp PRE-CREATION
src/slave/containerizer/provisioner/docker/spec.cpp PRE-CREATION
src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/38901/diff/
Testing
-------
make check (ubuntu 14.04 + clang++-3.6)
Thanks,
Gilbert Song
Re: Review Request 38901: Serialize Docker Image Spec as Protobuf
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38901/#review101156
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38901]
All tests passed.
- Mesos ReviewBot
On Sept. 30, 2015, 6:31 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38901/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2015, 6:31 p.m.)
>
>
> Review request for mesos, Jojy Varghese and Timothy Chen.
>
>
> Bugs: MESOS-2972
> https://issues.apache.org/jira/browse/MESOS-2972
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Serialize Docker Image Spec as Protobuf
>
>
> Diffs
> -----
>
> src/Makefile.am 8aa456611dd5405336dd7b0c19ba4a942ea1c805
> src/slave/containerizer/provisioner/docker/message.proto bbac2e6c1f40a7ca3f9227baca56a44cd43f58c6
> src/slave/containerizer/provisioner/docker/spec.hpp PRE-CREATION
> src/slave/containerizer/provisioner/docker/spec.cpp PRE-CREATION
> src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c
>
> Diff: https://reviews.apache.org/r/38901/diff/
>
>
> Testing
> -------
>
> make check (ubuntu 14.04 + clang++-3.6)
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 38901: Serialize Docker Image Spec as Protobuf
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38901/#review101197
-----------------------------------------------------------
src/slave/containerizer/provisioner/docker/message.proto (line 69)
<https://reviews.apache.org/r/38901/#comment158561>
We don't really need any of these yet.
src/slave/containerizer/provisioner/docker/message.proto (line 101)
<https://reviews.apache.org/r/38901/#comment158562>
Let's only add what we need for now
src/slave/containerizer/provisioner/docker/spec.hpp (line 39)
<https://reviews.apache.org/r/38901/#comment158563>
DockerImageManifest
- Timothy Chen
On Sept. 30, 2015, 6:31 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38901/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2015, 6:31 p.m.)
>
>
> Review request for mesos, Jojy Varghese and Timothy Chen.
>
>
> Bugs: MESOS-2972
> https://issues.apache.org/jira/browse/MESOS-2972
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Serialize Docker Image Spec as Protobuf
>
>
> Diffs
> -----
>
> src/Makefile.am 8aa456611dd5405336dd7b0c19ba4a942ea1c805
> src/slave/containerizer/provisioner/docker/message.proto bbac2e6c1f40a7ca3f9227baca56a44cd43f58c6
> src/slave/containerizer/provisioner/docker/spec.hpp PRE-CREATION
> src/slave/containerizer/provisioner/docker/spec.cpp PRE-CREATION
> src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c
>
> Diff: https://reviews.apache.org/r/38901/diff/
>
>
> Testing
> -------
>
> make check (ubuntu 14.04 + clang++-3.6)
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 38901: Serialize Docker Image Spec as Protobuf
Posted by Gilbert Song <gi...@mesoshere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38901/
-----------------------------------------------------------
(Updated Oct. 5, 2015, 12:14 p.m.)
Review request for mesos, Jojy Varghese and Timothy Chen.
Bugs: MESOS-2972
https://issues.apache.org/jira/browse/MESOS-2972
Repository: mesos
Description
-------
Serialize Docker Image Spec as Protobuf
Diffs (updated)
-----
src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983
src/Makefile.am f060998bb08cdb071db5a2e85dfbad805dab45e9
src/slave/containerizer/provisioner/docker/message.proto bbac2e6c1f40a7ca3f9227baca56a44cd43f58c6
src/slave/containerizer/provisioner/docker/spec.hpp PRE-CREATION
src/slave/containerizer/provisioner/docker/spec.cpp PRE-CREATION
src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/38901/diff/
Testing
-------
make check (ubuntu 14.04 + clang++-3.6)
Thanks,
Gilbert Song
Re: Review Request 38901: Serialize Docker Image Spec as Protobuf
Posted by Gilbert Song <gi...@mesoshere.io>.
> On Oct. 2, 2015, 3:38 p.m., Timothy Chen wrote:
> > src/tests/containerizer/provisioner_docker_tests.cpp, line 361
> > <https://reviews.apache.org/r/38901/diff/2/?file=1089086#file1089086line361>
> >
> > What's invalid about this JSON?
Because we have to make sure that we have at least one fsLayer blobSum and corresponding v1Compatibility, which is validated from validateManifest(const DockerImageManifest& manifest).
For here, history, fsLayers and signatures are missed.
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38901/#review101387
-----------------------------------------------------------
On Oct. 5, 2015, 12:14 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38901/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2015, 12:14 p.m.)
>
>
> Review request for mesos, Jojy Varghese and Timothy Chen.
>
>
> Bugs: MESOS-2972
> https://issues.apache.org/jira/browse/MESOS-2972
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Serialize Docker Image Spec as Protobuf
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983
> src/Makefile.am f060998bb08cdb071db5a2e85dfbad805dab45e9
> src/slave/containerizer/provisioner/docker/message.proto bbac2e6c1f40a7ca3f9227baca56a44cd43f58c6
> src/slave/containerizer/provisioner/docker/spec.hpp PRE-CREATION
> src/slave/containerizer/provisioner/docker/spec.cpp PRE-CREATION
> src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c
>
> Diff: https://reviews.apache.org/r/38901/diff/
>
>
> Testing
> -------
>
> make check (ubuntu 14.04 + clang++-3.6)
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 38901: Serialize Docker Image Spec as Protobuf
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38901/#review101387
-----------------------------------------------------------
src/slave/containerizer/provisioner/docker/spec.hpp (line 37)
<https://reviews.apache.org/r/38901/#comment158763>
End all comments with a period.
src/tests/containerizer/provisioner_docker_tests.cpp (line 321)
<https://reviews.apache.org/r/38901/#comment158765>
No need to abort, just use ASSERT_SOME
src/tests/containerizer/provisioner_docker_tests.cpp (line 357)
<https://reviews.apache.org/r/38901/#comment158767>
How about call it invalid instead of insufficient
src/tests/containerizer/provisioner_docker_tests.cpp (line 361)
<https://reviews.apache.org/r/38901/#comment158768>
What's invalid about this JSON?
src/tests/containerizer/provisioner_docker_tests.cpp (line 368)
<https://reviews.apache.org/r/38901/#comment158766>
ditto
- Timothy Chen
On Oct. 2, 2015, 8:10 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38901/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2015, 8:10 p.m.)
>
>
> Review request for mesos, Jojy Varghese and Timothy Chen.
>
>
> Bugs: MESOS-2972
> https://issues.apache.org/jira/browse/MESOS-2972
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Serialize Docker Image Spec as Protobuf
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983
> src/Makefile.am f060998bb08cdb071db5a2e85dfbad805dab45e9
> src/slave/containerizer/provisioner/docker/message.proto bbac2e6c1f40a7ca3f9227baca56a44cd43f58c6
> src/slave/containerizer/provisioner/docker/spec.hpp PRE-CREATION
> src/slave/containerizer/provisioner/docker/spec.cpp PRE-CREATION
> src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c
>
> Diff: https://reviews.apache.org/r/38901/diff/
>
>
> Testing
> -------
>
> make check (ubuntu 14.04 + clang++-3.6)
>
>
> Thanks,
>
> Gilbert Song
>
>
Re: Review Request 38901: Serialize Docker Image Spec as Protobuf
Posted by Gilbert Song <gi...@mesoshere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38901/
-----------------------------------------------------------
(Updated Oct. 2, 2015, 1:10 p.m.)
Review request for mesos, Jojy Varghese and Timothy Chen.
Bugs: MESOS-2972
https://issues.apache.org/jira/browse/MESOS-2972
Repository: mesos
Description
-------
Serialize Docker Image Spec as Protobuf
Diffs (updated)
-----
src/CMakeLists.txt 891f951f3107ece29b7923b7a3cc414e2ea56983
src/Makefile.am f060998bb08cdb071db5a2e85dfbad805dab45e9
src/slave/containerizer/provisioner/docker/message.proto bbac2e6c1f40a7ca3f9227baca56a44cd43f58c6
src/slave/containerizer/provisioner/docker/spec.hpp PRE-CREATION
src/slave/containerizer/provisioner/docker/spec.cpp PRE-CREATION
src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c
Diff: https://reviews.apache.org/r/38901/diff/
Testing
-------
make check (ubuntu 14.04 + clang++-3.6)
Thanks,
Gilbert Song
Re: Review Request 38901: Serialize Docker Image Spec as Protobuf
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38901/#review101139
-----------------------------------------------------------
src/Makefile.am (line 537)
<https://reviews.apache.org/r/38901/#comment158491>
Could we please add this file to the CMakeLists file in src/ also?
- Alex Clemmer
On Sept. 30, 2015, 6:31 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38901/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2015, 6:31 p.m.)
>
>
> Review request for mesos, Jojy Varghese and Timothy Chen.
>
>
> Bugs: MESOS-2972
> https://issues.apache.org/jira/browse/MESOS-2972
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Serialize Docker Image Spec as Protobuf
>
>
> Diffs
> -----
>
> src/Makefile.am 8aa456611dd5405336dd7b0c19ba4a942ea1c805
> src/slave/containerizer/provisioner/docker/message.proto bbac2e6c1f40a7ca3f9227baca56a44cd43f58c6
> src/slave/containerizer/provisioner/docker/spec.hpp PRE-CREATION
> src/slave/containerizer/provisioner/docker/spec.cpp PRE-CREATION
> src/tests/containerizer/provisioner_docker_tests.cpp d895eb9d0723e52cff8b21ef2deeaef1911d019c
>
> Diff: https://reviews.apache.org/r/38901/diff/
>
>
> Testing
> -------
>
> make check (ubuntu 14.04 + clang++-3.6)
>
>
> Thanks,
>
> Gilbert Song
>
>