Re: svn commit: r892977 - in /xmlgraphics/commons/trunk: src/java/org/apache/xmlgraphics/xmp/ src/java/org/apache/xmlgraphics/xmp/merge/ src/java/org/apache/xmlgraphics/xmp/schemas/ test/java/org/apache/xmlgraphics/xmp/

[Vincent Hennebert <vh...@gmail.com>]

Hi,

> Author: jeremias
> Date: Mon Dec 21 21:08:42 2009
> New Revision: 892977
> 
> URL: http://svn.apache.org/viewvc?rev=892977&view=rev
> Log:
> Added support for XMP Basic's Identifier property (uses qualifiers).
> Some simplifications.
<snip/>
> Modified: 
> xmlgraphics/commons/trunk/src/java/org/apache/xmlgraphics/xmp/XMPSchemaAdapter.java
> URL: http://svn.apache.org/viewvc/xmlgraphics/commons/trunk/src/java/org/apache/xmlgraphics/xmp/XMPSchemaAdapter.java?rev=892977&r1=892976&r2=892977&view=diff
> ==============================================================================
> --- xmlgraphics/commons/trunk/src/java/org/apache/xmlgraphics/xmp/XMPSchemaAdapter.java (original)
> +++ xmlgraphics/commons/trunk/src/java/org/apache/xmlgraphics/xmp/XMPSchemaAdapter.java Mon Dec 21 21:08:42 2009
> @@ -78,6 +78,19 @@
>          if (value == null || value.length() == 0) {
>              throw new IllegalArgumentException("Value must not be empty");
>          }
> +        addObjectToArray(propName, value, arrayType);
> +    }
> +
> +    /**
> +     * Adds a String value to an array.
> +     * @param propName the property name
> +     * @param value the String value
> +     * @param arrayType the type of array to operate on
> +     */
> +    protected void addObjectToArray(String propName, Object value, XMPArrayType arrayType) {
> +        if (value == null) {
> +            throw new IllegalArgumentException("Value must not be null");
> +        }
>          QName name = getQName(propName);
>          XMPProperty prop = meta.getProperty(name);
>          if (prop == null) {

The javadoc says String, the method name and parameter type say Object??

<snip/>

Vincent

---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: general-help@xmlgraphics.apache.org