You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aries.apache.org by "Mark Nuttall (JIRA)" <ji...@apache.org> on 2010/12/21 13:24:00 UTC
[jira] Created: (ARIES-521) Unsafe File construction in
ModelledResourceManagerImpl.findBlueprints()
Unsafe File construction in ModelledResourceManagerImpl.findBlueprints()
------------------------------------------------------------------------
Key: ARIES-521
URL: https://issues.apache.org/jira/browse/ARIES-521
Project: Aries
Issue Type: Bug
Components: Application
Affects Versions: 0.2, 0.1, 0.3, Incubation, 1.0
Reporter: Mark Nuttall
Assignee: Mark Nuttall
Fix For: 0.3, Incubation, 1.0
ModelledResourceManagerImpl.findBlueprints(Collection<IDirectory>) builds a File from IFile.toString(). This fails on Windows when the IFile has a space in its path name. Change IFile.toString to use IFile.toURL().toURI()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ARIES-521) Unsafe File construction in
ModelledResourceManagerImpl.findBlueprints()
Posted by "Mark Nuttall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Nuttall resolved ARIES-521.
--------------------------------
Resolution: Fixed
> Unsafe File construction in ModelledResourceManagerImpl.findBlueprints()
> ------------------------------------------------------------------------
>
> Key: ARIES-521
> URL: https://issues.apache.org/jira/browse/ARIES-521
> Project: Aries
> Issue Type: Bug
> Components: Application
> Affects Versions: 0.1, 0.2, 0.3, Incubation, 1.0
> Reporter: Mark Nuttall
> Assignee: Mark Nuttall
> Fix For: 0.3, Incubation, 1.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> ModelledResourceManagerImpl.findBlueprints(Collection<IDirectory>) builds a File from IFile.toString(). This fails on Windows when the IFile has a space in its path name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ARIES-521) Unsafe File construction in
ModelledResourceManagerImpl.findBlueprints()
Posted by "Mark Nuttall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Nuttall updated ARIES-521:
-------------------------------
Description: ModelledResourceManagerImpl.findBlueprints(Collection<IDirectory>) builds a File from IFile.toString(). This fails on Windows when the IFile has a space in its path name. (was: ModelledResourceManagerImpl.findBlueprints(Collection<IDirectory>) builds a File from IFile.toString(). This fails on Windows when the IFile has a space in its path name. Change IFile.toString to use IFile.toURL().toURI())
BundleManifest.fromBundle(IFile) is the right method to use. I then found a bug in that method in which we assumed that all directories in a path existed in their own right. In our itests, we see temporary bundles created in which META-INF/ is not a ZipFile entry, even though META-INF/MANIFEST.MF is.
> Unsafe File construction in ModelledResourceManagerImpl.findBlueprints()
> ------------------------------------------------------------------------
>
> Key: ARIES-521
> URL: https://issues.apache.org/jira/browse/ARIES-521
> Project: Aries
> Issue Type: Bug
> Components: Application
> Affects Versions: 0.1, 0.2, 0.3, Incubation, 1.0
> Reporter: Mark Nuttall
> Assignee: Mark Nuttall
> Fix For: 0.3, Incubation, 1.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> ModelledResourceManagerImpl.findBlueprints(Collection<IDirectory>) builds a File from IFile.toString(). This fails on Windows when the IFile has a space in its path name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ARIES-521) Unsafe File construction in
ModelledResourceManagerImpl.findBlueprints()
Posted by "Mark Nuttall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Nuttall updated ARIES-521:
-------------------------------
Remaining Estimate: 24h (was: 0.5h)
Original Estimate: 24h (was: 0.5h)
> Unsafe File construction in ModelledResourceManagerImpl.findBlueprints()
> ------------------------------------------------------------------------
>
> Key: ARIES-521
> URL: https://issues.apache.org/jira/browse/ARIES-521
> Project: Aries
> Issue Type: Bug
> Components: Application
> Affects Versions: 0.1, 0.2, 0.3, Incubation, 1.0
> Reporter: Mark Nuttall
> Assignee: Mark Nuttall
> Fix For: 0.3, Incubation, 1.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> ModelledResourceManagerImpl.findBlueprints(Collection<IDirectory>) builds a File from IFile.toString(). This fails on Windows when the IFile has a space in its path name. Change IFile.toString to use IFile.toURL().toURI()
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (ARIES-521) Unsafe File construction
in ModelledResourceManagerImpl.findBlueprints()
Posted by "Mark Nuttall (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12973671#action_12973671 ]
Mark Nuttall edited comment on ARIES-521 at 12/21/10 9:29 AM:
--------------------------------------------------------------
BundleManifest.fromBundle(IFile) is the right method to use. I then found a bug in ZipDirectory in which we assumed that all directories in a path existed in their own right. In our itests, we see temporary bundles created in which META-INF/ is not a ZipFile entry, even though META-INF/MANIFEST.MF is.
was (Author: mnuttall):
BundleManifest.fromBundle(IFile) is the right method to use. I then found a bug in that method in which we assumed that all directories in a path existed in their own right. In our itests, we see temporary bundles created in which META-INF/ is not a ZipFile entry, even though META-INF/MANIFEST.MF is.
> Unsafe File construction in ModelledResourceManagerImpl.findBlueprints()
> ------------------------------------------------------------------------
>
> Key: ARIES-521
> URL: https://issues.apache.org/jira/browse/ARIES-521
> Project: Aries
> Issue Type: Bug
> Components: Application
> Affects Versions: 0.1, 0.2, 0.3, Incubation, 1.0
> Reporter: Mark Nuttall
> Assignee: Mark Nuttall
> Fix For: 0.3, Incubation, 1.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> ModelledResourceManagerImpl.findBlueprints(Collection<IDirectory>) builds a File from IFile.toString(). This fails on Windows when the IFile has a space in its path name.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.