You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/03/26 12:02:10 UTC
[GitHub] [solr] janhoy opened a new pull request #763: SOLR-15852: Smoketester fixes for maven artifact comparison
janhoy opened a new pull request #763:
URL: https://github.com/apache/solr/pull/763
https://issues.apache.org/jira/browse/SOLR-15852
Smoketester fixes for 9.0 RC1
* Test of source tarball is now done on the `gradlew dev` output folder instead of inside source unpack where jars are missing
* Unique log-file names for java17 testing
* Do not require `solr-test-framework-x.x.x.jar` to be in binary release even if it a maven artifact
* Do not run `@Nighlty` tests in the smoketester, instead print a message to check recent Jenkins runs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #763: SOLR-15852: Smoketester fixes for maven artifact comparison
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #763:
URL: https://github.com/apache/solr/pull/763#discussion_r836542226
##########
File path: dev-tools/scripts/smokeTestRelease.py
##########
@@ -836,12 +827,15 @@ def checkIdenticalMavenArtifacts(distFiles, artifacts, version):
for artifact in artifacts:
if reJarWar.search(artifact):
artifactFilename = os.path.basename(artifact)
+ if artifactFilename in ['solr-test-framework-%s.jar' % version]:
+ print(' Skipping artifact %s as it should not be in the binary distribution' % artifactFilename)
Review comment:
Good idea - I added an explicit check (did not test it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on a change in pull request #763: SOLR-15852: Smoketester fixes for maven artifact comparison
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #763:
URL: https://github.com/apache/solr/pull/763#discussion_r836497260
##########
File path: dev-tools/scripts/smokeTestRelease.py
##########
@@ -706,11 +707,7 @@ def is_port_in_use(port):
def testSolrExample(unpackPath, javaPath, isSrc):
# test solr using some examples it comes with
logFile = '%s/solr-example.log' % unpackPath
- if isSrc:
- os.chdir(unpackPath+'/solr')
- subprocess.call(['chmod','+x',unpackPath+'/solr/bin/solr', unpackPath+'/solr/bin/solr.cmd', unpackPath+'/solr/bin/solr.in.cmd'])
Review comment:
The only thing is that this might fail on windows? I'm pretty sure the tar executable bits are lost when unpackaging on windows, but I could be wrong.
##########
File path: dev-tools/scripts/smokeTestRelease.py
##########
@@ -1090,11 +1084,10 @@ def main():
def smokeTest(java, baseURL, gitRevision, version, tmpDir, isSigned, local_keys, testArgs, downloadOnly=False):
startTime = datetime.datetime.now()
- # Tests annotated @Nightly are more resource-intensive but often cover
- # important code paths. They're disabled by default to preserve a good
- # developer experience, but we enable them for smoke tests where we want good
- # coverage. Still we disable @BadApple tests
- testArgs = '-Dtests.nightly=true -Dtests.badapples=false %s' % testArgs
+ # Avoid @Nightly and @Badapple tests as they are slow and buggy
+ # Instead verify that the recent Jenkins tests pass
+ print('NOTE: Not running @Nightly or @BadApple tests. Please verify that recent Jenkins runs have passed.')
+ testArgs = '-Dtests.nightly=false -Dtests.badapples=false %s' % testArgs
Review comment:
thanks you 👏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on a change in pull request #763: SOLR-15852: Smoketester fixes for maven artifact comparison
Posted by GitBox <gi...@apache.org>.
HoustonPutman commented on a change in pull request #763:
URL: https://github.com/apache/solr/pull/763#discussion_r836498671
##########
File path: dev-tools/scripts/smokeTestRelease.py
##########
@@ -1090,11 +1084,10 @@ def main():
def smokeTest(java, baseURL, gitRevision, version, tmpDir, isSigned, local_keys, testArgs, downloadOnly=False):
startTime = datetime.datetime.now()
- # Tests annotated @Nightly are more resource-intensive but often cover
- # important code paths. They're disabled by default to preserve a good
- # developer experience, but we enable them for smoke tests where we want good
- # coverage. Still we disable @BadApple tests
- testArgs = '-Dtests.nightly=true -Dtests.badapples=false %s' % testArgs
+ # Avoid @Nightly and @Badapple tests as they are slow and buggy
+ # Instead verify that the recent Jenkins tests pass
+ print('NOTE: Not running @Nightly or @BadApple tests. Please verify that recent Jenkins runs have passed.')
+ testArgs = '-Dtests.nightly=false -Dtests.badapples=false %s' % testArgs
Review comment:
thank you 👏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #763: SOLR-15852: Smoketester fixes for maven artifact comparison
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #763:
URL: https://github.com/apache/solr/pull/763#discussion_r836537176
##########
File path: dev-tools/scripts/smokeTestRelease.py
##########
@@ -626,22 +626,23 @@ def verifyUnpacked(java, artifact, unpackPath, gitRevision, version, testArgs):
print(" run tests w/ Java 11 and testArgs='%s'..." % testArgs)
java.run_java11('./gradlew --no-daemon test %s' % testArgs, '%s/test.log' % unpackPath)
- print(" compile jars w/ Java 11")
- java.run_java11('./gradlew --no-daemon jar -Dversion.release=%s' % version, '%s/compile.log' % unpackPath)
- print(" run interation tests w/ Java 11")
+ print(" run integration tests w/ Java 11")
java.run_java11('./gradlew --no-daemon integrationTest -Dversion.release=%s' % version, '%s/itest.log' % unpackPath)
- testSolrExample(unpackPath, java.java11_home, True)
+ print(" build binary release w/ Java 11")
+ java.run_java11('./gradlew --no-daemon dev -Dversion.release=%s' % version, '%s/compile.log' % unpackPath)
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy commented on a change in pull request #763: SOLR-15852: Smoketester fixes for maven artifact comparison
Posted by GitBox <gi...@apache.org>.
janhoy commented on a change in pull request #763:
URL: https://github.com/apache/solr/pull/763#discussion_r836535286
##########
File path: dev-tools/scripts/smokeTestRelease.py
##########
@@ -706,11 +707,7 @@ def is_port_in_use(port):
def testSolrExample(unpackPath, javaPath, isSrc):
# test solr using some examples it comes with
logFile = '%s/solr-example.log' % unpackPath
- if isSrc:
- os.chdir(unpackPath+'/solr')
- subprocess.call(['chmod','+x',unpackPath+'/solr/bin/solr', unpackPath+'/solr/bin/solr.cmd', unpackPath+'/solr/bin/solr.in.cmd'])
Review comment:
Now that we run the test from `solr/packaging/build/dev` I think we're ok due to https://github.com/apache/solr/blob/main/solr/packaging/build.gradle#L140 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on a change in pull request #763: SOLR-15852: Smoketester fixes for maven artifact comparison
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #763:
URL: https://github.com/apache/solr/pull/763#discussion_r836524450
##########
File path: dev-tools/scripts/smokeTestRelease.py
##########
@@ -836,12 +827,15 @@ def checkIdenticalMavenArtifacts(distFiles, artifacts, version):
for artifact in artifacts:
if reJarWar.search(artifact):
artifactFilename = os.path.basename(artifact)
+ if artifactFilename in ['solr-test-framework-%s.jar' % version]:
+ print(' Skipping artifact %s as it should not be in the binary distribution' % artifactFilename)
Review comment:
do we want to explicitly test that it was not included? I thought there was a check against extra files but I can't find it now.
##########
File path: dev-tools/scripts/smokeTestRelease.py
##########
@@ -626,22 +626,23 @@ def verifyUnpacked(java, artifact, unpackPath, gitRevision, version, testArgs):
print(" run tests w/ Java 11 and testArgs='%s'..." % testArgs)
java.run_java11('./gradlew --no-daemon test %s' % testArgs, '%s/test.log' % unpackPath)
- print(" compile jars w/ Java 11")
- java.run_java11('./gradlew --no-daemon jar -Dversion.release=%s' % version, '%s/compile.log' % unpackPath)
- print(" run interation tests w/ Java 11")
+ print(" run integration tests w/ Java 11")
java.run_java11('./gradlew --no-daemon integrationTest -Dversion.release=%s' % version, '%s/itest.log' % unpackPath)
- testSolrExample(unpackPath, java.java11_home, True)
+ print(" build binary release w/ Java 11")
+ java.run_java11('./gradlew --no-daemon dev -Dversion.release=%s' % version, '%s/compile.log' % unpackPath)
Review comment:
Should we call this `assemble.log` or compile could still be ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] janhoy merged pull request #763: SOLR-15852: Smoketester fixes for maven artifact comparison
Posted by GitBox <gi...@apache.org>.
janhoy merged pull request #763:
URL: https://github.com/apache/solr/pull/763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org