You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/18 22:48:38 UTC

[GitHub] [arrow] boshek commented on a change in pull request #12435: ARROW-15679: [R] count should return an ungrouped dataframe

boshek commented on a change in pull request #12435:
URL: https://github.com/apache/arrow/pull/12435#discussion_r810385764



##########
File path: r/R/dplyr-count.R
##########
@@ -25,12 +25,13 @@ count.arrow_dplyr_query <- function(x, ..., wt = NULL, sort = FALSE, name = NULL
   }
   out <- dplyr::tally(out, wt = {{ wt }}, sort = sort, name = name)
 
-  # Restore original group vars
   gv <- dplyr::group_vars(x)
-  if (length(gv)) {
+  if (rlang::is_empty(gv)) {

Review comment:
       That makes sense. Thanks for the feedback!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org