You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/02 02:22:57 UTC

[GitHub] [flink] klion26 commented on a change in pull request #10349: [FLINK-14833] [runtime] Remove hierachy of SnapshotStrategySynchronicityBehavior in HeapSnapshotStrategy

klion26 commented on a change in pull request #10349: [FLINK-14833] [runtime] Remove hierachy of SnapshotStrategySynchronicityBehavior in HeapSnapshotStrategy
URL: https://github.com/apache/flink/pull/10349#discussion_r352398276
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapSnapshotStrategy.java
 ##########
 @@ -60,8 +60,7 @@
  * Base class for the snapshots of the heap backend that outlines the algorithm and offers some hooks to realize
 
 Review comment:
   Here the java doc said that "Base class", but there is no subclass for `HeapSnapshotStrategy`, do you think we should we should update the java doc also? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services