You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "dishant1691 (via GitHub)" <gi...@apache.org> on 2023/06/30 06:01:53 UTC

[GitHub] [superset] dishant1691 opened a new issue, #24561: Older Dates in charts is showing as NAN.

dishant1691 opened a new issue, #24561:
URL: https://github.com/apache/superset/issues/24561

   Hello, I am using superset version 2.1.0
   
   For older dates around year 1937 and back I am not able to see correct dates in chart, it is showing as NAN.
   Although in dataset it is being shown correctly.
   
   Database I have checked Databricks SQL, SQL server.
   
   For example I have created a simple table chart by using this dummy date in dataset:
   
   select  (current_date() - 31150 ) as dt1 the chart shows NAN value
   
   <img width="260" alt="image" src="https://github.com/apache/superset/assets/123067038/c90eeee6-09fa-424c-8da2-cb90e6b4d66a">
   
   But if I run this select  (current_date() - 31105) as dt1, it shows correct date
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] sfirke commented on issue #24561: Older Dates with Year 1937 or less in charts is showing as NAN.

Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on issue #24561:
URL: https://github.com/apache/superset/issues/24561#issuecomment-1618294638

   I can replicate this bug with SQL Server and Superset 2.1.0.
   
   1. Run this query in SQL Lab and save as a data set:
   ```
   select (GETDATE() - 31150 ) as dt1,
   (GETDATE() - 31100 ) as dt2
   ```
   
   2. In the resulting chart creation view, the first date appears as NaN:
   
   ![image](https://github.com/apache/superset/assets/7569808/b88146ac-e79d-422f-b2c2-3b850581fc95)
   
   I don't know what's happening here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] sfirke commented on issue #24561: Older Dates with Year 1937 or less in charts is showing as NAN.

Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on issue #24561:
URL: https://github.com/apache/superset/issues/24561#issuecomment-1674790039

   I just tested this on 3.0.0rc2 and it appears fixed there.  Following my steps above I get: 
   ![image](https://github.com/apache/superset/assets/7569808/60a880e6-559c-4b90-9b53-23ec0c9db4a1)
   
   Maybe it was fixed by https://github.com/apache/superset/pull/23339 ? h/t to @justinpark for making the connection.  At any rate, I'm going to close this issue.  Please feel free to re-open or reply if this occurs again in 3.0.0 or latest.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] dishant1691 commented on issue #24561: Older Dates with Year 1937 or less in charts is showing as NAN.

Posted by "dishant1691 (via GitHub)" <gi...@apache.org>.
dishant1691 commented on issue #24561:
URL: https://github.com/apache/superset/issues/24561#issuecomment-1614681571

   I am getting exact date
   <img width="119" alt="image" src="https://github.com/apache/superset/assets/123067038/68c20625-689f-43a0-b5b2-3ba753b23bbd">
   
   but when trying to show them in Charts it shows NAN


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] sfirke commented on issue #24561: Older Dates with Year 1937 or less in charts is showing as NAN.

Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on issue #24561:
URL: https://github.com/apache/superset/issues/24561#issuecomment-1614644619

   What do you get when you run the same SQL query directly against the database, without Superset?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] dishant1691 commented on issue #24561: Older Dates with Year 1937 or less in charts is showing as NAN.

Posted by "dishant1691 (via GitHub)" <gi...@apache.org>.
dishant1691 commented on issue #24561:
URL: https://github.com/apache/superset/issues/24561#issuecomment-1617591333

   @sfirke Can you please check if this issue is version specific in charts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] sfirke closed issue #24561: Older Dates with Year 1937 or less in charts is showing as NAN.

Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke closed issue #24561: Older Dates with Year 1937 or less in charts is showing as NAN.
URL: https://github.com/apache/superset/issues/24561


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] sfirke commented on issue #24561: Older Dates with Year 1937 or less in charts is showing as NAN.

Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on issue #24561:
URL: https://github.com/apache/superset/issues/24561#issuecomment-1621822736

   I agree it seems like a bug in Superset.  There's not really anyone "from Superset" because it's an open-source project without a single owner.  Anyone could submit a pull request to fix this.  I don't think it will be a priority for most people because it doesn't affect anyone who isn't using old year values.
   
   If you're able to poke around in the Superset code to figure this out, that would be ideal.  Otherwise one thing you might be able to do is try testing this on different versions of Superset.  If it's fixed in the new 3.0.0rc1, great.  If nothing else, try other date values and see if you can learn anything.  Does 1838 work?  Is there a max date that returns this same NaN?
   
   I thought it could be related to Pandas dates out of bounds, but 1938 seems too modern for that: https://pandas.pydata.org/docs/user_guide/timeseries.html#timestamp-limitations


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] dishant1691 commented on issue #24561: Older Dates with Year 1937 or less in charts is showing as NAN.

Posted by "dishant1691 (via GitHub)" <gi...@apache.org>.
dishant1691 commented on issue #24561:
URL: https://github.com/apache/superset/issues/24561#issuecomment-1621208598

   @sfirke 
   Do you know someone from Superset who can help me on this as this seems to be an issue with Superset charts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org