You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Stephan Erb <st...@dev.static-void.de> on 2015/04/14 20:51:29 UTC
Review Request 33184: Implement missing != operator for AuroraJobKey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33184/
-----------------------------------------------------------
Review request for Aurora.
Repository: aurora
Description
-------
Implement missing \!= operator for AuroraJobKey
>From the Python docu of __ne__: "There are no implied relationships among the comparison operators. The truth of x==y does not imply that x!=y is false. Accordingly, when defining __eq__(), one should also define __ne__() so that the operators will behave as expected."
Diffs
-----
src/main/python/apache/aurora/common/aurora_job_key.py 88896c6c41235f44447d313f0d77682acdca7cce
src/test/python/apache/aurora/common/test_aurora_job_key.py 7d8d58b541f16d63495f46b58bd928e8f53f66d1
Diff: https://reviews.apache.org/r/33184/diff/
Testing
-------
./pants test.pytest --no-fast --options=-v src/test/python/apache/aurora/common::
Thanks,
Stephan Erb
Re: Review Request 33184: Implement missing != operator for
AuroraJobKey
Posted by Stephan Erb <st...@dev.static-void.de>.
> On April 14, 2015, 8:53 p.m., Bill Farner wrote:
> > src/test/python/apache/aurora/common/test_aurora_job_key.py, line 25
> > <https://reviews.apache.org/r/33184/diff/1/?file=927354#file927354line25>
> >
> > Can you test the inverse as well - keys that are not equal?
Added. It is a little bit longer as we have to test all combinations.
- Stephan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33184/#review80079
-----------------------------------------------------------
On April 14, 2015, 9:18 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33184/
> -----------------------------------------------------------
>
> (Updated April 14, 2015, 9:18 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implement missing != operator for AuroraJobKey
>
> From the Python docu of __ne__: "There are no implied relationships among the comparison operators. The truth of x==y does not imply that x!=y is false. Accordingly, when defining __eq__(), one should also define __ne__() so that the operators will behave as expected."
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/common/aurora_job_key.py 88896c6c41235f44447d313f0d77682acdca7cce
> src/test/python/apache/aurora/common/test_aurora_job_key.py 7d8d58b541f16d63495f46b58bd928e8f53f66d1
>
> Diff: https://reviews.apache.org/r/33184/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast --options=-v src/test/python/apache/aurora/common::
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 33184: Implement missing != operator for
AuroraJobKey
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33184/#review80079
-----------------------------------------------------------
src/test/python/apache/aurora/common/test_aurora_job_key.py
<https://reviews.apache.org/r/33184/#comment129848>
Can you test the inverse as well - keys that are not equal?
- Bill Farner
On April 14, 2015, 6:51 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33184/
> -----------------------------------------------------------
>
> (Updated April 14, 2015, 6:51 p.m.)
>
>
> Review request for Aurora.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Implement missing \!= operator for AuroraJobKey
>
> From the Python docu of __ne__: "There are no implied relationships among the comparison operators. The truth of x==y does not imply that x!=y is false. Accordingly, when defining __eq__(), one should also define __ne__() so that the operators will behave as expected."
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/common/aurora_job_key.py 88896c6c41235f44447d313f0d77682acdca7cce
> src/test/python/apache/aurora/common/test_aurora_job_key.py 7d8d58b541f16d63495f46b58bd928e8f53f66d1
>
> Diff: https://reviews.apache.org/r/33184/diff/
>
>
> Testing
> -------
>
> ./pants test.pytest --no-fast --options=-v src/test/python/apache/aurora/common::
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 33184: Implement missing != operator for
AuroraJobKey
Posted by Stephan Erb <st...@dev.static-void.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33184/
-----------------------------------------------------------
(Updated April 14, 2015, 9:18 p.m.)
Review request for Aurora.
Changes
-------
Test inequality explicitly.
Repository: aurora
Description
-------
Implement missing != operator for AuroraJobKey
>From the Python docu of __ne__: "There are no implied relationships among the comparison operators. The truth of x==y does not imply that x!=y is false. Accordingly, when defining __eq__(), one should also define __ne__() so that the operators will behave as expected."
Diffs (updated)
-----
src/main/python/apache/aurora/common/aurora_job_key.py 88896c6c41235f44447d313f0d77682acdca7cce
src/test/python/apache/aurora/common/test_aurora_job_key.py 7d8d58b541f16d63495f46b58bd928e8f53f66d1
Diff: https://reviews.apache.org/r/33184/diff/
Testing
-------
./pants test.pytest --no-fast --options=-v src/test/python/apache/aurora/common::
Thanks,
Stephan Erb
Re: Review Request 33184: Implement missing != operator for
AuroraJobKey
Posted by Stephan Erb <st...@dev.static-void.de>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33184/
-----------------------------------------------------------
(Updated April 14, 2015, 8:54 p.m.)
Review request for Aurora.
Repository: aurora
Description (updated)
-------
Implement missing != operator for AuroraJobKey
>From the Python docu of __ne__: "There are no implied relationships among the comparison operators. The truth of x==y does not imply that x!=y is false. Accordingly, when defining __eq__(), one should also define __ne__() so that the operators will behave as expected."
Diffs
-----
src/main/python/apache/aurora/common/aurora_job_key.py 88896c6c41235f44447d313f0d77682acdca7cce
src/test/python/apache/aurora/common/test_aurora_job_key.py 7d8d58b541f16d63495f46b58bd928e8f53f66d1
Diff: https://reviews.apache.org/r/33184/diff/
Testing
-------
./pants test.pytest --no-fast --options=-v src/test/python/apache/aurora/common::
Thanks,
Stephan Erb