[jira] [Commented] (CALCITE-5686) Generalize return types of the linq4j expression shuttle

["Julian Hyde (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-5686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17738278#comment-17738278 ] 

Julian Hyde commented on CALCITE-5686:
--------------------------------------

I removed 'fixVersion = 1.35' because there is no PR. However, I agree that the proposed changes would be useful.

[~thomas.rebele], If you provide a PR shortly I will try to get it merged in before 1.35.

> Generalize return types of the linq4j expression shuttle
> --------------------------------------------------------
>
>                 Key: CALCITE-5686
>                 URL: https://issues.apache.org/jira/browse/CALCITE-5686
>             Project: Calcite
>          Issue Type: Improvement
>            Reporter: Thomas Rebele
>            Assignee: Thomas Rebele
>            Priority: Major
>
> The following block in org.apache.calcite.linq4j.tree.Shuttle prevents replacing constants with other expressions:
> {code:java}
>   public ConstantExpression visit(ConstantExpression constantExpression) {
>     return constantExpression;
>   } {code}
> The return type of the corresponding accept function is more general:
> {code:java}
> @Override public Expression accept(Shuttle shuttle) {
>     return shuttle.visit(this);
>   } {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)