[incubator-pinot] branch master updated: [TE] populate the feedback in DTO for child anomalies (#4301)

[ji...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

jihao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new d4474b9  [TE] populate the feedback in DTO for child anomalies (#4301)
d4474b9 is described below

commit d4474b9248dac200e3935f6a83955e12dafc8632
Author: Jihao Zhang <ji...@linkedin.com>
AuthorDate: Tue Jun 11 10:31:49 2019 -0700

    [TE] populate the feedback in DTO for child anomalies (#4301)
    
    Previously, the DTO for the child anomaly is loaded with the model mapper, which won't populate the feedbacks object. This PR fixes the issue by explicitly converting it into a DTO.
---
 .../thirdeye/datalayer/bao/jdbc/MergedAnomalyResultManagerImpl.java     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/bao/jdbc/MergedAnomalyResultManagerImpl.java b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/bao/jdbc/MergedAnomalyResultManagerImpl.java
index 3940a2e..fd972dd 100644
--- a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/bao/jdbc/MergedAnomalyResultManagerImpl.java
+++ b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/datalayer/bao/jdbc/MergedAnomalyResultManagerImpl.java
@@ -456,7 +456,7 @@ public class MergedAnomalyResultManagerImpl extends AbstractManagerImpl<MergedAn
         }
 
         MergedAnomalyResultBean childBean = genericPojoDao.get(id, MergedAnomalyResultBean.class);
-        MergedAnomalyResultDTO child = MODEL_MAPPER.map(childBean, MergedAnomalyResultDTO.class);
+        MergedAnomalyResultDTO child = convertMergedAnomalyBean2DTO(childBean);
         children.add(child);
       }
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org