[GitHub] [incubator-uniffle] advancedxy commented on a diff in pull request #1137: [#825][part-1] feat(spark): Add the RPC interface for reassigning ShuffleServer

["advancedxy (via GitHub)" <gi...@apache.org>]

advancedxy commented on code in PR #1137:
URL: https://github.com/apache/incubator-uniffle/pull/1137#discussion_r1293472406


##########
proto/src/main/proto/Rss.proto:
##########
@@ -393,6 +395,21 @@ message GetShuffleServerRequest {
   int32 estimateTaskConcurrency = 11;
 }
 
+message GetReShuffleServerRequest {
+  string clientHost = 1;
+  string clientPort = 2;
+  string clientProperty = 3;
+  string applicationId = 4;
+  int32 shuffleId = 5;
+  int32 partitionNum = 6;
+  int32 partitionNumPerRange = 7;
+  int32 dataReplica = 8;
+  repeated string requireTags = 9;
+  int32 assignmentShuffleServerNumber = 10;
+  int32 estimateTaskConcurrency = 11;
+  repeated string shuffleServerIds = 12;

Review Comment:
   I think a better name would be `excludeServerIds` or `faultyServerIds`. And I think we can simply merge this interface with `GetShuffleServerRequest`. 
   
   Also, I think it might be valuable to add a new interface, such as `ReportFaultyShuffleServers` from AM/driver to coordinator so that coordinator could decide whether which shuffle servers to exclude when a few AMs/drivers repeatedly report some shuffle servers are faulty.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org