You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/07/08 07:26:23 UTC
[GitHub] [incubator-eventmesh] kirinzhu opened a new issue, #1009: [Enhancement] Remove the redundant nullcheck of value previously dereferenced
kirinzhu opened a new issue, #1009:
URL: https://github.com/apache/incubator-eventmesh/issues/1009
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
It seems that the value value which is checked here can't be null because it was previously dereferenced and if it were null a null pointer exception would have occurred at the earlier dereference.
1st appearance:
In module eventmesh-runtime
In class org.apache.eventmesh.runtime.boot.EventMeshServer
In method org.apache.eventmesh.runtime.boot.EventMeshServer.init()
Value loaded from field org.apache.eventmesh.runtime.boot.EventMeshServer.eventMeshHttpConfiguration
Redundant null check at EventMeshServer.java:[line 108]
2nd appearance:
In module eventmesh-runtime
In class org.apache.eventmesh.runtime.boot.EventMeshServer
In method org.apache.eventmesh.runtime.boot.EventMeshServer.init()
Value loaded from field org.apache.eventmesh.runtime.boot.EventMeshServer.eventMeshHttpConfiguration
Redundant null check at EventMeshServer.java:[line 108]
### Describe the solution you'd like
Maybe we could remove the redundant nullcheck
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] misselvexu commented on issue #1009: [Enhancement] Remove the redundant nullcheck of value previously dereferenced
Posted by GitBox <gi...@apache.org>.
misselvexu commented on issue #1009:
URL: https://github.com/apache/incubator-eventmesh/issues/1009#issuecomment-1180141243
I will finish this issue .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen closed issue #1009: [Enhancement] Remove the redundant nullcheck of value previously dereferenced
Posted by GitBox <gi...@apache.org>.
qqeasonchen closed issue #1009: [Enhancement] Remove the redundant nullcheck of value previously dereferenced
URL: https://github.com/apache/incubator-eventmesh/issues/1009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org