You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "dataroaring (via GitHub)" <gi...@apache.org> on 2023/04/25 02:10:15 UTC
[GitHub] [doris] dataroaring commented on a diff in pull request #18758: [feature-wip](duplicate_no_keys) add create duplicate table without keys
dataroaring commented on code in PR #18758:
URL: https://github.com/apache/doris/pull/18758#discussion_r1174875563
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -3770,7 +3776,7 @@ public static short calcShortKeyColumnCount(List<Column> columns, Map<String, St
}
++shortKeyColumnCount;
}
- if (shortKeyColumnCount == 0) {
+ if (isDupNoKeys != true && shortKeyColumnCount == 0) {
Review Comment:
same as above.
##########
be/src/olap/tablet.h:
##########
@@ -138,6 +138,7 @@ class Tablet : public BaseTablet {
double bloom_filter_fpp() const;
size_t next_unique_id() const;
size_t row_size() const;
+ bool duplicate_no_keys() const;
Review Comment:
keys_type && num_key_nums is enough.
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -3707,16 +3711,18 @@ public void setHaProtocol(HAProtocol protocol) {
this.haProtocol = protocol;
}
- public static short calcShortKeyColumnCount(List<Column> columns, Map<String, String> properties)
- throws DdlException {
+ public static short calcShortKeyColumnCount(List<Column> columns, Map<String, String> properties,
+ boolean isDupNoKeys) throws DdlException {
Review Comment:
passing keysType is a better way.
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -3707,16 +3711,18 @@ public void setHaProtocol(HAProtocol protocol) {
this.haProtocol = protocol;
}
- public static short calcShortKeyColumnCount(List<Column> columns, Map<String, String> properties)
- throws DdlException {
+ public static short calcShortKeyColumnCount(List<Column> columns, Map<String, String> properties,
+ boolean isDupNoKeys) throws DdlException {
List<Column> indexColumns = new ArrayList<Column>();
for (Column column : columns) {
if (column.isKey()) {
indexColumns.add(column);
}
}
LOG.debug("index column size: {}", indexColumns.size());
- Preconditions.checkArgument(indexColumns.size() > 0);
+ if (isDupNoKeys != true) {
Review Comment:
if (!isDupNoKeys)
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java:
##########
@@ -2593,7 +2596,7 @@ private void createTablets(String clusterName, MaterializedIndex index, ReplicaS
/*
* generate and check columns' order and key's existence
*/
- private void validateColumns(List<Column> columns) throws DdlException {
Review Comment:
passing keysType may be a better way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org