[jira] [Commented] (SOLR-3989) RuntimeException thrown by SolrZkClient should wrap cause, have a message, or be SolrException

["Commit Tag Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-3989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13610556#comment-13610556 ] 

Commit Tag Bot commented on SOLR-3989:
--------------------------------------

[branch_4x commit] Yonik Seeley
http://svn.apache.org/viewvc?view=revision&revision=1408512

SOLR-3989: SolrZkClient constructor dropped exception cause when throwing a new RuntimeException

                
> RuntimeException thrown by SolrZkClient should wrap cause, have a message, or be SolrException
> ----------------------------------------------------------------------------------------------
>
>                 Key: SOLR-3989
>                 URL: https://issues.apache.org/jira/browse/SOLR-3989
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - java
>    Affects Versions: 4.0
>            Reporter: Colin Bartolome
>            Assignee: Yonik Seeley
>             Fix For: 4.1, 5.0
>
>
> In a few spots, but notably in the constructor for SolrZkClient, a try-catch block will catch Throwable and throw a new RuntimeException with no cause or message. Either the RuntimeException should wrap the Throwable that was caught, some sort of message should be added, or the type of the exception should be changed to SolrException so calling code can catch these exceptions without casting too broad of a net.
> Reproduce this by creating a CloudSolrServer that points to a URL that is valid, but has no server running:
> CloudSolrServer server = new CloudSolrServer("localhost:9983");
> server.connect();

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org