[GitHub] [superset] wiktor2200 commented on a change in pull request #17880: feat: Helm - custom service account creation and management

[GitBox <gi...@apache.org>]

wiktor2200 commented on a change in pull request #17880:
URL: https://github.com/apache/superset/pull/17880#discussion_r776308752



##########
File path: helm/superset/values.yaml
##########
@@ -25,6 +25,11 @@ replicaCount: 1
 # Runn containers as root is not recommended in production. Change this to another UID - e.g. 1000 to be more secure
 runAsUser: 0
 
+# Create custom service account for Superset. If create: true and name is not provided, superset.fullname will be used.
+# serviceAccountName: superset
+serviceAccount:
+  create: false

Review comment:
       I've thought about it. That was even my first choice, but then I've noticed that, there was `ServiceAccountName` variable added in the past #15340, so I've implemented new feature as enhancement beside the current solution.
   I don't want to destroy any configs that can exist somewhere.
   @mvoitko and @craig-rueda can you give some more feedback about this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org